Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non square boards would break scraper #468

Open
climu opened this issue Dec 26, 2021 · 0 comments
Open

Non square boards would break scraper #468

climu opened this issue Dec 26, 2021 · 0 comments
Labels

Comments

@climu
Copy link
Owner

climu commented Dec 26, 2021

We should change have a way to check if board size is square. At the moment a non square board would raise such:

  File "/openstudyroom/league/models.py", line 521, in parse
    prop = utils.parse_sgf_string(self.sgf_text)
  File "/openstudyroom/league/utils.py", line 175, in parse_sgf_string
    out['board_size'] = int(out['board_size'])
ValueError: invalid literal for int() with base 10: '19:9'
@climu climu added the bug label Dec 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant