Skip to content
This repository has been archived by the owner on May 10, 2021. It is now read-only.

update random-access-rn-file #3

Open
chrmod opened this issue Apr 28, 2020 · 4 comments
Open

update random-access-rn-file #3

chrmod opened this issue Apr 28, 2020 · 4 comments

Comments

@chrmod
Copy link
Member

chrmod commented Apr 28, 2020

Current version does not work anymore due to changes to react-native-fs. The proper full path to file has to be provided:

const prefix = RNFS.DocumentDirectoryPath+'/';

Additionally a support for folders would be nice:

export default (folder) => (name) => {

@chrmod
Copy link
Member Author

chrmod commented Apr 28, 2020

@RangerMauve maybe you can take a look :-)

@RangerMauve
Copy link

Oof, I'd strongly consider migrating to use nodejs-mobile or something similar. The pefromance hit of serializing and deserializing the FS calls was painfully slow from when @allain and I were looking at it a while ago. 😅

@martinheidegger
Copy link

With turbo-modules this should become a lot faster, I do have some other thoughts on how to improve this.

@RangerMauve
Copy link

Yeah, if you can get the performance working decently with RN the UX would be way nicer for app authors.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants