Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

primitive-math #67

Closed
KingMob opened this issue Jan 28, 2022 · 3 comments
Closed

primitive-math #67

KingMob opened this issue Jan 28, 2022 · 3 comments
Assignees

Comments

@KingMob
Copy link

KingMob commented Jan 28, 2022

@ztellman @slipset @piotr-yuxuan

Piotr requested some ns changes to an old, archived library of Zach's, primitive-math. They wanted to deprecate the top-level namespace and move code into a multi-segmented ns, as top-level namespaces cause some issues with using GraalVM in clj-easy's graal-build-time.

If we're going to make a change, I'd like to bring primitive-math under the clj-commons umbrella, if that's ok.

@danielcompton
Copy link
Member

danielcompton commented Feb 8, 2022

If Zach is happy to migrate primitive math, we should also take a look at removing this line:

https://github.com/ztellman/primitive-math/blob/7654d4c86a6a93639dd4d6d074a1fcb5ee64ebc2/project.clj#L15

I was doing some work on Java build stuff a while ago (can't remember if it was with Graal or jdeps) and having an old class file version caused issues. Sorry I can't remember the specifics, it wasn't a blocker for anything, but I think it might have prevented some optimisations.

@ztellman
Copy link

ztellman commented Feb 8, 2022

Yeah, absolutely happy to migrate it over.

On a related note, it's been suggested that this repo I created when I worked at Factual could be transferred over, as well: clj-commons/durable-queue#23. I would expect exceedingly few changes to this repo over time, currently the only outstanding work are some new type-hints to better work with Java 13, but since I can't currently deploy new releases under the Factual org, it needs to be forked/transferred somewhere to make those small changes.

@ztellman
Copy link

ztellman commented Feb 8, 2022

primitive-math has been transferred over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants