Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git submodule add #9

Open
sysadmin-info opened this issue Apr 6, 2023 · 5 comments
Open

git submodule add #9

sysadmin-info opened this issue Apr 6, 2023 · 5 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed question Further information is requested

Comments

@sysadmin-info
Copy link

sysadmin-info commented Apr 6, 2023

Should not it be rather this way?

git submodule add https://github.com/cljoly/gohugo-asciinema.git themes/gohugo-asciinema
@cljoly
Copy link
Owner

cljoly commented Apr 7, 2023

Thanks for opening this issue. Are you suggesting to add this to the README, as an alternative installation option?

@sysadmin-info
Copy link
Author

I suppose that this could be done. I tried this and is working properly. The only one thing is also worth to buy mention that sometimes the theme like zzo theme dominates over the asciinema player css stylesheet. I observed this and had to enable custom.css on zzo theme to change some elements by using ! important to not override styles from asciinema. Dirty workaround, but it is working. Hard to explain, because I should present it on the screen. What is interesting, is the fact that when I am using a generated script exactly for my videos it loads css from asciinema server. So will have to find out how to to tell the theme to ignore zzo css stylesheet in the part of the website where the asciinema shortcode is located. I have no idea is it possible, but I will figure it out. The behavior is that currently the zzo theme loads different background color in the asciinema video, so background: none ! important; in custom.css solves the problem.

@cljoly
Copy link
Owner

cljoly commented Apr 10, 2023

Hum, ok, I think I see.

I have no idea is it possible, but I will figure it out

Please feel free to further comment on this issue (you can attach screenshots if you want) and we will see if there is something we can document in this plugin to make it easier to use in the case you describe. How does that sound to you @sysadmin-info ?

@sysadmin-info
Copy link
Author

sysadmin-info commented Apr 24, 2023

I was a webmaster for many years, so I am able to solve it for good. But I need a time to sit down and perform an analysis to find out is it possible to do anything on asciinema side to behave the way that css will be treated properly by each theme. Developer tools and time are needed - that I currently do not have. Probably after May 3rd I will be able to do that and write a tutorial what to do and provide a permanent solution.

@cljoly
Copy link
Owner

cljoly commented Apr 30, 2023

Great, thank you!

@cljoly cljoly added help wanted Extra attention is needed good first issue Good for newcomers question Further information is requested labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants