You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I want to store non-string data on the nodes in a tree e.g. a matrix of numbers.
However, as the Node attributes are of type string | string[] I can't store the matrix (https://github.com/clockor2/phylojs/blob/main/src/tree/node.ts#L180). Would we be okay to change the type to include numbers or I can even see the utility of more complex datatypes.
I want to store non-string data on the nodes in a tree e.g. a matrix of numbers.
However, as the Node attributes are of type
string | string[]
I can't store the matrix (https://github.com/clockor2/phylojs/blob/main/src/tree/node.ts#L180). Would we be okay to change the type to include numbers or I can even see the utility of more complex datatypes.You could then move the complexities of reading and writing these types of annotations to the custom user defined annotation readers/writers (https://github.com/clockor2/phylojs/blob/main/src/io/writers/newick.ts#L13).
Relates to #68 as we don't currently support user defined annotation parsers.
The text was updated successfully, but these errors were encountered: