From 1338b7e99fec5c0b10f0f71e8aa0632c0d8d581a Mon Sep 17 00:00:00 2001 From: Ingvar Stepanyan Date: Mon, 6 Jan 2025 19:48:17 +0000 Subject: [PATCH 1/4] Attempt to fix CI I don't know when or why this broke (or, rather, how it worked before), but we're installing .NET 7 but packing BSATN.Runtime that multi-targets .NET Standard 2.1 + .NET 8. The latter part, as you'd expect, fails on CI. This change tells `dotnet pack` to only pack for .NET Standard 2.1 since that's the one we're interested in on the client - .NET 8 support is only for C# server modules. --- .github/workflows/dotnet.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/dotnet.yml b/.github/workflows/dotnet.yml index 643a1628..75e1a97b 100644 --- a/.github/workflows/dotnet.yml +++ b/.github/workflows/dotnet.yml @@ -29,7 +29,7 @@ jobs: - name: Setup SpacetimeDB packages working-directory: spacetimedb-csharp-sdk run: | - ( cd ../SpacetimeDB/crates/bindings-csharp/BSATN.Runtime && dotnet pack ) + dotnet pack ../SpacetimeDB/crates/bindings-csharp/BSATN.Runtime /p:TargetFramework=netstandard2.1 # Write out the nuget config file to `nuget.config`. This causes the spacetimedb-csharp-sdk repository # to be aware of the local versions of the `bindings-csharp` packages in SpacetimeDB, and use them if From 7e60f97be4851d03f9a7983b570019b891ac914c Mon Sep 17 00:00:00 2001 From: Ingvar Stepanyan Date: Mon, 6 Jan 2025 19:49:47 +0000 Subject: [PATCH 2/4] Switch to .NET 8 SDK as well --- .github/workflows/dotnet.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/dotnet.yml b/.github/workflows/dotnet.yml index 75e1a97b..52963d5f 100644 --- a/.github/workflows/dotnet.yml +++ b/.github/workflows/dotnet.yml @@ -20,7 +20,7 @@ jobs: - name: Setup .NET uses: actions/setup-dotnet@v4 with: - dotnet-version: 7.0.x + dotnet-version: 8.0.x - name: Checkout SpacetimeDB uses: actions/checkout@v4 with: From 3febebaad283d331abe40fda20abb34a8c5b6285 Mon Sep 17 00:00:00 2001 From: Ingvar Stepanyan Date: Mon, 6 Jan 2025 19:52:19 +0000 Subject: [PATCH 3/4] uhhh --- .github/workflows/dotnet.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/dotnet.yml b/.github/workflows/dotnet.yml index 52963d5f..623a0121 100644 --- a/.github/workflows/dotnet.yml +++ b/.github/workflows/dotnet.yml @@ -29,7 +29,7 @@ jobs: - name: Setup SpacetimeDB packages working-directory: spacetimedb-csharp-sdk run: | - dotnet pack ../SpacetimeDB/crates/bindings-csharp/BSATN.Runtime /p:TargetFramework=netstandard2.1 + dotnet pack ../SpacetimeDB/crates/bindings-csharp/BSATN.Runtime /p:TargetFrameworks=netstandard2.1 # Write out the nuget config file to `nuget.config`. This causes the spacetimedb-csharp-sdk repository # to be aware of the local versions of the `bindings-csharp` packages in SpacetimeDB, and use them if From e1519d58aff377d98bb3b7b8e6eacbe17262301e Mon Sep 17 00:00:00 2001 From: Ingvar Stepanyan Date: Mon, 6 Jan 2025 19:53:07 +0000 Subject: [PATCH 4/4] i give up --- .github/workflows/dotnet.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/dotnet.yml b/.github/workflows/dotnet.yml index 623a0121..40dbd7ab 100644 --- a/.github/workflows/dotnet.yml +++ b/.github/workflows/dotnet.yml @@ -29,7 +29,7 @@ jobs: - name: Setup SpacetimeDB packages working-directory: spacetimedb-csharp-sdk run: | - dotnet pack ../SpacetimeDB/crates/bindings-csharp/BSATN.Runtime /p:TargetFrameworks=netstandard2.1 + dotnet pack ../SpacetimeDB/crates/bindings-csharp/BSATN.Runtime # Write out the nuget config file to `nuget.config`. This causes the spacetimedb-csharp-sdk repository # to be aware of the local versions of the `bindings-csharp` packages in SpacetimeDB, and use them if