Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugger breaks on macros that require &env (like async.core/go) #372

Closed
collinalexbell opened this issue Aug 25, 2016 · 5 comments
Closed
Labels

Comments

@collinalexbell
Copy link

>> (defn [foo] (go [] foo))

This will crash 0.14.0-SNAPSHOT

An issue is open in cider repo that provides more information. clojure-emacs/cider#1775

The basic fix is to use https://github.com/ztellman/riddley as the macroexpander instead of walk/macroexpand-all

I have already written a patch. It seems to work on my machine. There is one problem, which is that the original form does not get saved into metadata as ::original-form. I will submit a pull request, but perhaps this part will need to be fixed.

@bbatsov
Copy link
Member

bbatsov commented Sep 3, 2016

@Malabarba Guess you'll have to take a look at the proposed solution.

@royalaid
Copy link

royalaid commented Jun 7, 2017

Any status updates on this issue?

@Malabarba
Copy link
Member

Not from me, sorry. 😢

@vemv
Copy link
Member

vemv commented Jan 17, 2022

See also clojure-emacs/orchard#77 (comment)

@vemv vemv closed this as completed Jan 17, 2022
@vemv
Copy link
Member

vemv commented Jan 17, 2022

As some additional info, looks like with project Loom, the go macro will be fundamentally simpler, so we might get a 80% solution for free.

Also, anyway go is backed by a thread pool (today and also after Loom), and the debugger doesn't support arbitrary threads #630 (comment), so maybe &env wouldn't have given us that much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants