Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick Start mentions stack trace which no longer appears #305

Open
mfikes opened this issue Mar 21, 2019 · 2 comments
Open

Quick Start mentions stack trace which no longer appears #305

mfikes opened this issue Mar 21, 2019 · 2 comments
Labels

Comments

@mfikes
Copy link
Member

mfikes commented Mar 21, 2019

In Quick Start:

Let’s make a mistake. Try evaluating (ffirst [1]). You should get a source mapped stack trace ...

But with recent changes stack traces are no longer printed by default:

ClojureScript 1.10.516
cljs.user=> (ffirst [1])
Execution error (Error) at (<cljs repl>:1).
1 is not ISeqable
@mfikes
Copy link
Member Author

mfikes commented Mar 21, 2019

Potential solution:

Change the language to read:

Let’s make a mistake. Try evaluating (ffirst [1]) followed by (pst).

The REPL experience at that point might look like

ClojureScript 1.10.516
cljs.user=> (ffirst [1])
Execution error (Error) at (<cljs repl>:1).
1 is not ISeqable

cljs.user=> (pst)
Error: 1 is not ISeqable
	 cljs.core/seq (out/cljs/core.cljs:1226:20)
	 cljs.core/first (out/cljs/core.cljs:1235:16)
	 cljs$core$ffirst (out/cljs/core.cljs:1751:4)

@swannodette
Copy link
Member

Sounds good to me, PR welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants