-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin no longer works on osTicket 1.18 #63
Comments
Can also confirm that the same problem exists with 1.17.5 |
[10-Nov-2023 06:34:06 UTC] PHP Fatal error: Cannot make non static method Plugin::getInstance() static in class AttachmentPreviewPlugin in /include/plugins/attachment_preview/class.AttachmentPreviewPlugin.php on line 83 |
Same issue here. |
Hi everyone, We found a temporary solution for this bug, simply install this plugin in Chrome or Edge: After install you must allow the active content (javascript) and File URL permission in the plugin's settings. |
Hello, I will test the chrome app but it would be nice if the plugin could be updated. Best regards |
Hello, I'm using this plugin with osTicket 1.18.1 with apache server, after initial challenges now works great, need to add new header in your apache virtualhost config: |
Tested, it works! |
@impedator does not work for me, pdfs still only showing blank. |
@buff0k did you checked browser console for errors when opening page with ticket? please provide some info about environment. |
@impedator the issue I am geetting now is: Note that I am using Nginx with the header included by: I'm going to check other headers that might conflict. |
@buff0k - try: add_header Content-Security-Policy "object-src '*' blob:;"; and check if this is working ok, if yes then investigate proper domain or source, remember that it is not a good idea to use * there ;-) |
@impedator So Nginx is applying both policies but neither is passing it through as it runs into the none policy, I need to figure out what is setting that. |
Look this -> osTicket/osTicket#6624 |
changes related to clonemeagain/attachment_preview#63
Any news? I have currently applied changes by @impedator impedator/osTicket@3e40543#diff-9d3ede82cbb2ca67574bfe9f98bf9ccce84ccb967cadf16cb0ed80ce66d64363R3 |
This works for v1.17.5 updated to: old: |
I can confirm that this works in v1.18.1 as well. |
I upgraded my osTicket deployment to 1.18.1 and discovered that the plugin no longer functions. Am looking into the code but I suspect it may ba the javascript not really playing nice with osTicket 1.18.
The text was updated successfully, but these errors were encountered: