Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicting PERFILE_DAX flag #65

Open
bsbernd opened this issue Apr 15, 2022 · 3 comments
Open

Conflicting PERFILE_DAX flag #65

bsbernd opened this issue Apr 15, 2022 · 3 comments

Comments

@bsbernd
Copy link

bsbernd commented Apr 15, 2022

Incompatible PERFILE_DAX flag. I only noticed about this project as Vivek Goyal pointed me to it on the fsdevel list and I checked used flags because of this patch https://marc.info/?l=linux-fsdevel&m=165002361802294&w=2
And then noticed that PERFILE_DAX flag is conflicting with FUSE_INIT_EXT

Looks like you are on a non-upstream kernel with patches?

linux master include/uapi/linux/fuse.h

...
#define FUSE_INIT_EXT (1 << 30)
#define FUSE_INIT_RESERVED (1 << 31)
/* bits 32..63 get shifted down 32 bits into the flags2 field */
#define FUSE_SECURITY_CTX (1ULL << 32)
#define FUSE_HAS_INODE_DAX (1ULL << 33)

Btw, any reason you are not using 1 << number for the flags? In my personal opinion so much easier to read...

@jiangliu
Copy link
Contributor

Thanks for reminder:)
The current valued is used for early per-file DAX patch versions. The value has been changed just before merging the PR. And we are lacked behind to update fuse-backend-rs to the latest code:)
Also PR is welcomed here:)

https://lwn.net/Articles/838916/

@jiangliu
Copy link
Contributor

Btw, any reason you are not using 1 << number for the flags? In my personal opinion so much easier to read...

That's a good suggestion. The current coding style is derived from original work from the crosvm project. And we are happy to improve code readability.

@adamqqqplay
Copy link
Contributor

@bsbernd Hi, looks like PR #105 fixed this issue. Maybe you can upgrade the dependencies soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants