fix: Fixed Tflint warnings

Author: pranaydeokar

_example/basic/example.tf

@@ -2,53 +2,6 @@ provider "azurerm" {
   features {}
 }
 
-locals {
-  name        = "app"
-  environment = "test"
-  label_order = ["name", "environment"]
-}
-
-module "resource_group" {
-  source      = "clouddrove/resource-group/azure"
-  version     = "1.0.2"
-  name        = "app"
-  environment = "test"
-  label_order = ["name", "environment"]
-  location    = "Canada Central"
-}
-
-##-----------------------------------------------------------------------------
-## Virtual Network module call.
-##-----------------------------------------------------------------------------
-module "vnet" {
-  source              = "clouddrove/vnet/azure"
-  version             = "1.0.4"
-  name                = "app"
-  environment         = "test"
-  resource_group_name = module.resource_group.resource_group_name
-  location            = module.resource_group.resource_group_location
-  address_spaces      = ["10.0.0.0/16"]
-}
-
-##-----------------------------------------------------------------------------
-## Subnet module call.
-##-----------------------------------------------------------------------------
-module "name_specific_subnet" {
-  source               = "clouddrove/subnet/azure"
-  version              = "1.0.2"
-  name                 = "app"
-  environment          = "test"
-  resource_group_name  = module.resource_group.resource_group_name
-  location             = module.resource_group.resource_group_location
-  virtual_network_name = module.vnet.vnet_name
-
-  #subnet
-  specific_name_subnet  = true
-  specific_subnet_names = "AzureBastionSubnet"
-  subnet_prefixes       = ["10.0.1.0/24"]
-  enable_route_table    = false
-
-}
 ##-----------------------------------------------------------------------------
 ## Bastion module call.
 ##-----------------------------------------------------------------------------

_example/basic/outputs.tf

@@ -1,10 +1,10 @@
 output "bastion_dns_name" {
-  value       = join("", module.bastion.*.dns_name)
+  value       = module.bastion.dns_name
   description = "Specifies the name of the bastion host"
 }
 
 output "bastion_id" {
-  value       = join("", module.bastion.*.id)
+  value       = module.bastion.id
   description = "Specifies the name of the bastion host"
 }
 

_example/complete/example.tf

@@ -77,14 +77,13 @@ module "log-analytics" {
 ## Bastion module call.
 ##-----------------------------------------------------------------------------
 module "bastion" {
-  depends_on           = [module.resource_group]
-  source               = "./../../"
-  name                 = "app"
-  environment          = "test"
-  resource_group_name  = module.resource_group.resource_group_name
-  location             = module.resource_group.resource_group_location
-  virtual_network_name = module.vnet.vnet_name
-  subnet_id            = module.name_specific_subnet.specific_subnet_id[0]
+  depends_on          = [module.resource_group]
+  source              = "./../../"
+  name                = "app"
+  environment         = "test"
+  resource_group_name = module.resource_group.resource_group_name
+  location            = module.resource_group.resource_group_location
+  subnet_id           = module.name_specific_subnet.specific_subnet_id[0]
 
   ##-----------------------------------------------------------------------------
   ## enable diagnostic setting

_example/complete/outputs.tf

@@ -1,10 +1,10 @@
 output "bastion_dns_name" {
-  value       = join("", module.bastion.*.dns_name)
+  value       = module.bastion.dns_name
   description = "Specifies the name of the bastion host"
 }
 
 output "bastion_id" {
-  value       = join("", module.bastion.*.id)
+  value       = module.bastion.id
   description = "Specifies the name of the bastion host"
 }
 

outputs.tf

@@ -1,9 +1,9 @@
 output "dns_name" {
-  value       = join("", azurerm_bastion_host.main.*.dns_name)
+  value       = azurerm_bastion_host.main[0].dns_name
   description = "Specifies the name of the bastion host"
 }
 
 output "id" {
-  value       = join("", azurerm_bastion_host.main.*.id)
+  value       = azurerm_bastion_host.main[0].id
   description = "Specifies the resource id of the bastion host"
 }

variables.tf

@@ -18,11 +18,6 @@ variable "label_order" {
   description = "Label order, e.g. sequence of application name and environment `name`,`environment`,'attribute' [`webserver`,`qa`,`devops`,`public`,] ."
 }
 
-variable "tags" {
-  type        = map(string)
-  default     = {}
-  description = "Additional tags (e.g. map(`BusinessUnit`,`XYZ`)."
-}
 
 variable "managedby" {
   type        = string
@@ -43,12 +38,6 @@ variable "location" {
   description = "A location the resources"
 }
 
-variable "virtual_network_name" {
-  type        = string
-  default     = null
-  description = "The name of the virtual network"
-}
-
 variable "public_ip_allocation_method" {
   type        = string
   default     = "Static"
@@ -62,11 +51,6 @@ variable "public_ip_sku" {
   description = "The SKU of the Public IP. Accepted values are Basic and Standard. Defaults to Basic"
 }
 
-variable "azure_bastion_subnet_address_prefix" {
-  type        = list(any)
-  default     = []
-  description = "The address prefix to use for the Azure Bastion subnet"
-}
 
 variable "enable_copy_paste" {
   type        = bool
@@ -159,23 +143,6 @@ variable "log_analytics_destination_type" {
   description = "Possible values are AzureDiagnostics and Dedicated, default to AzureDiagnostics. When set to Dedicated, logs sent to a Log Analytics workspace will go into resource specific tables, instead of the legacy AzureDiagnostics table."
 }
 
-variable "retention_policy_enabled" {
-  type        = bool
-  default     = false
-  description = "Is this Retention Policy enabled?"
-}
-
-variable "diagnostic_log_days" {
-  type        = number
-  default     = "90"
-  description = " The number of days for which this Retention Policy should apply."
-}
-
-variable "Metric_enable" {
-  type        = bool
-  default     = true
-  description = "Is this Diagnostic Metric enabled? Defaults to true."
-}
 
 variable "diagnostic_setting_enable" {
   type    = bool
@@ -187,11 +154,6 @@ variable "log_analytics_workspace_id" {
   default = null
 }
 
-variable "category" {
-  type        = string
-  default     = null
-  description = " The name of a Diagnostic Log Category Group for this Resource."
-}
 
 variable "log_enabled" {
   type        = string