Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings in ecs.j2 template - roles/config/cluster/ecs/templates/configs/ecs.j2 #241

Open
hadoopch opened this issue Jun 27, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@hadoopch
Copy link

Hi,

i checked the ecs.j2 template today.

There is an unknown parameter set for Docker:

  • docker_images_destination_registry_user (i can't find it in CM)

Furthermore longhorn_replication ist set to 1.

In my opinion best practise would be to skip this parameter or set it to 2.
If you skip it then

  • target_redundancy

will define the number of longhorn replica.
target_redundancy has a default value of 2.

Regards

Uli

@wmudge wmudge self-assigned this Jul 17, 2024
@wmudge
Copy link
Member

wmudge commented Jul 17, 2024

Hi Uli! I spent a bit of time looking into these points. I agree with you on the longhorn_replication; we should set it to 2. As to the docker_images_destination_registry_user, I'm still reviewing and will get back to you.

@clevesque
Copy link
Contributor

clevesque commented Jul 19, 2024

"longhorn_replication" maps directly to LH global settings, the param "target_redundancy" was added to facilitate single node CDSW to CML migration.
So in 99% of the case, just supply a value for longhorn_replication (almost always = 2).

So yes I would say that ecs.j2 could be improved by defaulting to 2 (and not 1).

@wmudge wmudge added the enhancement New feature or request label Jul 24, 2024
@wmudge wmudge added this to the Release 4.5.0 milestone Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

3 participants