Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pages]Update Hexo framework guides, remove unnecessary steps #18931

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

ousugo
Copy link
Contributor

@ousugo ousugo commented Dec 25, 2024

Summary

According to the Hexo official documentation, when hexo init is executed, the dependency installation is complete and there is no need to perform npm install to install the dependency.
image

Screenshots (optional)

Documentation checklist

  • The documentation style guide has been adhered to.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • Files which have changed name or location have been allocated redirects.

@ToriLindsay
Copy link
Contributor

@dario-piotrowicz @jculvey @GregBrimble Would someone mind just confirming this line is ok to remove? Seems that way from the documentation they linked but I just want to double check. Thanks!

Copy link
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! thanks for the fix @ousugo 🫶


Thanks for the ping @ToriLindsay, I do think the change is definitely correct 👍

@dario-piotrowicz dario-piotrowicz merged commit 97f12e9 into cloudflare:production Jan 20, 2025
7 checks passed
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes a docs contribution, big or small label Jan 20, 2025
Copy link

holopin-bot bot commented Jan 20, 2025

Congratulations @ousugo, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm65bmzqx49470cl809ebvmcr

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution [Holopin] Recognizes a docs contribution, big or small product:pages size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants