Skip to content

Commit 4ee6a95

Browse files
committed
set script as a positional arg
1 parent 4851955 commit 4ee6a95

File tree

4 files changed

+33
-2
lines changed

4 files changed

+33
-2
lines changed

.changeset/three-toys-feel.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"wrangler": patch
3+
---
4+
5+
fix: script should be accepted as a positional arg in the `versions upload` command

packages/wrangler/src/__tests__/versions/versions.help.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ describe("versions --help", () => {
1818
COMMANDS
1919
wrangler versions view <version-id> View the details of a specific version of your Worker
2020
wrangler versions list List the 10 most recent Versions of your Worker
21-
wrangler versions upload Uploads your Worker code and config as a new Version
21+
wrangler versions upload [script] Uploads your Worker code and config as a new Version
2222
wrangler versions deploy [version-specs..] Safely roll out new Versions of your Worker by splitting traffic between multiple Versions
2323
wrangler versions secret Generate a secret that can be referenced in a Worker
2424
@@ -50,7 +50,7 @@ describe("versions subhelp", () => {
5050
COMMANDS
5151
wrangler versions view <version-id> View the details of a specific version of your Worker
5252
wrangler versions list List the 10 most recent Versions of your Worker
53-
wrangler versions upload Uploads your Worker code and config as a new Version
53+
wrangler versions upload [script] Uploads your Worker code and config as a new Version
5454
wrangler versions deploy [version-specs..] Safely roll out new Versions of your Worker by splitting traffic between multiple Versions
5555
wrangler versions secret Generate a secret that can be referenced in a Worker
5656

packages/wrangler/src/__tests__/versions/versions.upload.test.ts

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,31 @@ describe("versions upload", () => {
122122
`);
123123
});
124124

125+
test("should accept script as a positional arg", async () => {
126+
mockGetScript();
127+
mockUploadVersion(false);
128+
129+
// Setup
130+
writeWranglerConfig({
131+
name: "test-name",
132+
// i.e. would error if the arg wasn't picked up
133+
main: "./nope.js",
134+
});
135+
writeWorkerSource();
136+
setIsTTY(false);
137+
138+
const result = runWrangler("versions upload index.js");
139+
140+
await expect(result).resolves.toBeUndefined();
141+
142+
expect(std.out).toMatchInlineSnapshot(`
143+
"Total Upload: xx KiB / gzip: xx KiB
144+
Worker Startup Time: 500 ms
145+
Uploaded test-name (TIMINGS)
146+
Worker Version ID: 51e4886e-2db7-4900-8d38-fbfecfeab993"
147+
`);
148+
});
149+
125150
test("should print preview url if version has preview", async () => {
126151
mockGetScript();
127152
mockUploadVersion(true);

packages/wrangler/src/versions/upload.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,7 @@ export const versionsUploadCommand = createCommand({
104104
owner: "Workers: Authoring and Testing",
105105
status: "stable",
106106
},
107+
positionalArgs: ["script"],
107108
args: {
108109
script: {
109110
describe: "The path to an entry point for your Worker",

0 commit comments

Comments
 (0)