Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web-storybook): create storybook setup & refactor for separation of concerns #5570

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

sulmoJ
Copy link
Member

@sulmoJ sulmoJ commented Jan 20, 2025

Skip Review (optional)

  • Minor changes that don't affect the functionality (e.g. style, chore, ci, test, docs)
  • Previously reviewed in feature branch, further review is not mandatory
  • Self-merge allowed for solo developers or urgent changes

Description (optional)

I have created a Storybook for the console components.
To achieve this, I have separated the concerns within the repository into distinct packages:

  • postcss-config-custom

    • This package includes default configurations for TailwindCSS.
  • mirinae-foundation

    • This package manages the foundational style settings for all packages.
  • storybook-config-custom

    • This package contains the base configuration settings for Storybook.

콘솔 컴포넌트를 위한 스토리북을 생성했습니다.
이를 위해 현재 레포의 패키지 관심사 분리를 진행하였습니다.

  • postcss-config-custom
    • tailwindcss 기본 설정값을 추가하였습니다.
  • mirinae-foundation
    • 모든 패키지의 스타일 기본 값들을 관리합니다.
  • storybook-config-custom
    • 스토리북 기본 세팅값을 분리하였습니다.

Things to Talk About (optional)

refactor: restructure styles and update imports

- Moved style files to a new package directory
- Updated import paths for colors, screens, and fonts
- Added mirinae-foundation as a dependency in package.json

Signed-off-by: sulmo <[email protected]>

refactor(tailwind): simplify config by extending default settings

- Replaced custom Tailwind configuration with an extended default config
- Removed redundant theme, variants, and plugins definitions
- Updated content paths for style processing

Signed-off-by: sulmo <[email protected]>
Copy link

vercel bot commented Jan 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
console ⬜️ Ignored (Inspect) Visit Preview Jan 20, 2025 9:58am
dashboard ⬜️ Ignored (Inspect) Visit Preview Jan 20, 2025 9:58am

@github-actions github-actions bot added pass/signedoff pending/review Pull Request is awaiting review. No reviewers have started reviewing yet. labels Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pass/signedoff pending/review Pull Request is awaiting review. No reviewers have started reviewing yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant