Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create legacy evaluate expression & add legacy-warning UI #4631

Merged

Conversation

piggggggggy
Copy link
Member

To Reviewers

  • Skip (style, chore, ci, minor refactoring, etc.)
  • Need discussion
  • Not that difficult
  • Approved feature branch merge to master

Description

SSIA

Things to Talk About

Copy link

vercel bot commented Sep 2, 2024

@piggggggggy is attempting to deploy a commit to the cloudforet Team on Vercel.

A member of the Team first needs to authorize it.

Signed-off-by: samuel.park <[email protected]>
@piggggggggy piggggggggy merged commit f3135b5 into cloudforet-io:feature-dashboard-v2 Sep 2, 2024
2 of 3 checks passed
Copy link
Member

@skdud4659 skdud4659 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@piggggggggy piggggggggy deleted the legacy-eval branch September 2, 2024 23:58
piggggggggy added a commit that referenced this pull request Sep 2, 2024
#4632)

* fix: create legacy evaluate expression & add legacy-warning UI



* chore: translation



* chore: solve small bug



---------

Signed-off-by: samuel.park <[email protected]>
Co-authored-by: yuda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants