Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logic to delete user_secret when disabling MFA if mfa_type is OTP #398

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Add logic to delete user_secret when disabling MFA if mfa_type is OTP #398

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a647715
feat: Add logic to delete user_secret when disabling MFA if mfa_type …
lhhyung Oct 21, 2024
8cd86ed
feat: Add logic to delete user_secret when disabling MFA if mfa_type …
lhhyung Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/spaceone/identity/service/user_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

from spaceone.identity.error.error_mfa import *
from spaceone.identity.error.error_user import *
from spaceone.identity.manager import SecretManager
from spaceone.identity.manager.config_manager import ConfigManager
from spaceone.identity.manager.email_manager import EmailManager
from spaceone.identity.manager.domain_manager import DomainManager
Expand Down Expand Up @@ -250,6 +251,11 @@ def disable_mfa(self, params: UserDisableMFARequest) -> Union[UserResponse, dict
if user_mfa.get("state", "DISABLED") == "DISABLED" or mfa_type is None:
raise ERROR_MFA_ALREADY_DISABLED(user_id=user_id)

if mfa_type == "OTP":
user_secret_id = user_mfa.get("options", {}).get("user_secret_id")
secret_manager: SecretManager = self.locator.get_manager(SecretManager)
secret_manager.delete_user_secret(user_secret_id)

user_mfa = {"state": "DISABLED"}
self.user_mgr.update_user_by_vo({"mfa": user_mfa}, user_vo)

Expand Down
Loading