Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we remove the reporter aspect of the CATs config? #528

Open
ctlong opened this issue Apr 21, 2022 · 1 comment
Open

Should we remove the reporter aspect of the CATs config? #528

ctlong opened this issue Apr 21, 2022 · 1 comment

Comments

@ctlong
Copy link
Member

ctlong commented Apr 21, 2022

Context

The reporter_config key in the CATs config allows a honeycomb reporter to be registered.

The reporter is registered with ginkgo here:

reporterConfig := Config.GetReporterConfig()
if reporterConfig.HoneyCombDataset != "" && reporterConfig.HoneyCombWriteKey != "" {
honeyCombClient := client.New(libhoney.Config{
WriteKey: reporterConfig.HoneyCombWriteKey,
Dataset: reporterConfig.HoneyCombDataset,
})
globalTags := map[string]interface{}{
"run_id": os.Getenv("RUN_ID"),
"env_api": Config.GetApiEndpoint(),
}
honeyCombReporter := honeycomb.New(honeyCombClient)
honeyCombReporter.SetGlobalTags(globalTags)
honeyCombReporter.SetCustomTags(reporterConfig.CustomTags)
rs = append(rs, honeyCombReporter)
}
RunSpecsWithDefaultAndCustomReporters(t, "CATS", rs)

We don't reference the reporter config anywhere in the README.

Questions

  • Was this included specifically for past maintainers or was the community at large interested in reporting to honeycomb?
  • Does anyone register a honeycomb key in their CATs runs and/or look at the results in a honeycomb dashboard?
  • Is it worth removing this thing?
@ctlong ctlong mentioned this issue Jun 15, 2022
7 tasks
@ameowlia
Copy link
Member

ameowlia commented Jun 15, 2022

Was this included specifically for past maintainers or was the community at large interested in reporting to honeycomb?

I think there was a particular pivot who led this initiative. They are no longer working on Cloud Foundry. I do not think there was any community involvement.

Does anyone register a honeycomb key in their CATs runs and/or look at the results in a honeycomb dashboard?

AFAIK we haven't used honeycomb in years.

Is it worth removing this thing?

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Waiting on feedback
Development

No branches or pull requests

2 participants