Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Klaus to UAA #695

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Add Klaus to UAA #695

merged 2 commits into from
Oct 9, 2023

Conversation

strehle
Copy link
Member

@strehle strehle commented Sep 29, 2023

Please add https://github.com/klaus-sap

He will participate in UAA contributes, he did some PR in the past

https://github.com/search?q=repo%3Acloudfoundry%2Fuaa+klaus-sap&type=pullrequests

@strehle
Copy link
Member Author

strehle commented Sep 29, 2023

FYI @cloudfoundry/wg-foundational-infrastructure-identity-and-auth-uaa-approvers

@beyhan
Copy link
Member

beyhan commented Oct 9, 2023

According to the Promotion to Reviewer or Approver rules this pr needs to be approved by two approves.

@beyhan beyhan added the wg label Oct 9, 2023
@strehle
Copy link
Member Author

strehle commented Oct 9, 2023

@beyhan Approved from my side

Copy link
Member

@beyhan beyhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Klaus doesn't seem to be a contributor yet. Could you please also add him the the https://github.com/cloudfoundry/community/blob/main/org/contributors.yml.

@strehle strehle requested a review from beyhan October 9, 2023 13:09
Copy link
Contributor

@Tallicia Tallicia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by me as well

@beyhan beyhan merged commit a69fac1 into cloudfoundry:main Oct 9, 2023
2 checks passed
@strehle strehle deleted the patch-1 branch October 9, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants