[Bug]: CFPackage resources may leak after app deletion

[danail-branekov]

What happened?

CI e2e test failure: https://ci.korifi.cf-app.com/builds/14653297

The app deletion e2e test deletes the app, awaits for the deletion job to complete and then checks that the getting the app and the package returns HTTP 404. However, the check that the package is gone has failed in this occurance.

Upon app deletion the CFPackage referenced is not deleted explicitly. The way this is expected to work is that the package controller upon reconciling a package would set an ownership relation from the app to the package. This is somewhat racy as the app might be deleted prior the package controller manages to reconcile the package. Then, on app deletion the CFPackage resource would remain behind.

What you expected to happen

• The test not to flake
• CFPackages do not remain after app being deleted

Acceptance Criteria

See above

How to reproduce it (as minimally and precisely as possible)

This is hard to reproduce, could not achieve it locally. However, the CI managed to

Anything else we need to know?

Related slack thread: https://cloudfoundry.slack.com/archives/C0297673ASK/p1689169941354209

Environment

Revision of codebase: 6316626