Skip to content

Commit dcfa4d3

Browse files
authored
Merge pull request #515 from cloudfoundry/go125-integration
close more conns for websocket apps
2 parents 21975f5 + ee357d6 commit dcfa4d3

File tree

3 files changed

+4
-0
lines changed

3 files changed

+4
-0
lines changed

src/code.cloudfoundry.org/gorouter/integration/route_services_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -174,6 +174,7 @@ var _ = Describe("Route services", func() {
174174

175175
Expect(err).NotTo(HaveOccurred())
176176
Expect(string(msgBuf[:num2])).To(Equal("WEBSOCKET OK"))
177+
wsConn.Close()
177178

178179
Eventually(func() ([]byte, error) {
179180
return os.ReadFile(testState.AccessLogFilePath())

src/code.cloudfoundry.org/gorouter/proxy/proxy_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1781,6 +1781,7 @@ var _ = Describe("Proxy", func() {
17811781

17821782
g.Expect(err).NotTo(HaveOccurred())
17831783
g.Expect(string(msgBuf[:n])).To(Equal("WEBSOCKET OK"))
1784+
conn.Close()
17841785

17851786
g.Eventually(func() (int64, error) {
17861787
fi, err := f.Stat()

src/code.cloudfoundry.org/gorouter/test/websocket_app.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ func NewWebSocketApp(urls []route.Uri, rPort uint16, mbusClient *nats.Conn, dela
2626

2727
conn, _, err := w.(http.Hijacker).Hijack()
2828
Expect(err).ToNot(HaveOccurred())
29+
defer conn.Close()
2930
x := test_util.NewHttpConn(conn)
3031

3132
resp := test_util.NewResponse(http.StatusSwitchingProtocols)
@@ -54,6 +55,7 @@ func NewFailingWebSocketApp(urls []route.Uri, rPort uint16, mbusClient *nats.Con
5455

5556
conn, _, err := w.(http.Hijacker).Hijack()
5657
Expect(err).ToNot(HaveOccurred())
58+
defer conn.Close()
5759
x := test_util.NewHttpConn(conn)
5860
err = x.Close()
5961
Expect(err).ToNot(HaveOccurred())

0 commit comments

Comments
 (0)