Skip to content

SPA mode is failing if . is in URL #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gjuchault opened this issue Apr 19, 2018 · 2 comments
Closed

SPA mode is failing if . is in URL #203

gjuchault opened this issue Apr 19, 2018 · 2 comments

Comments

@gjuchault
Copy link

gjuchault commented Apr 19, 2018 •
edited
Loading

As you're using if (argv['spa'] && request.url.indexOf(".") == -1) { (which is here because you want to 404 on real files not found).

But ! If we use query string parameters with . inside, such as:

url.com/path/subpath?email=john.cena@gmail.com

then it matches the indexOf, while we still want the path to resolve as SPA.

I might open a PR when I have some time.
gjuchault added a commit to gjuchault/node-static that referenced this issue Apr 19, 2018
@gjuchault
fix(spa): parse URL before matching files for 404
2dadf24 
Fixes cloudhead#203
@gjuchault gjuchault mentioned this issue Apr 19, 2018
Closed
@gjuchault
Copy link
Author

PR opened: #204

@brettz9
Copy link
Collaborator

brettz9 commented May 21, 2021

Closed by #227.

@brettz9 brettz9 closed this as completed May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(spa): parse URL before matching files for 404 gjuchault/node-static
2 participants
@brettz9 @gjuchault