[Feature] Subpaths #435
Assignees
Comments
This was referenced Feb 22, 2024
Closed
Open
Closed
12 tasks
colbyfayock
pushed a commit
that referenced
this issue
Sep 27, 2024
# Description This PR switches away from tsup to preconstruct - a lesser-known but more capable tool. The benefits are: - better cjs & esm setup - and types for the above (this should pass https://arethetypeswrong.github.io/ checks) - `'use client'` directive support. With this you just can just add the directive to any of your files and Preconstruct takes care of isolating that in its own chunk - `package.json#exports` flexibility: - it should be possible to add extra entrypoints with ease if you ever need that (like `next-cloudinary/something`) - it's also easy to use differential bundling with this, if you ever need to ship different code for dev/prov bundles, or for node/browser/webworker/vercel's edge-light/younameit (or perhaps for `react-server` condition) ## Issue Ticket Number Related to #435 ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Fix or improve the documentation - [ ] This change requires a documentation update # Checklist - [x] I have followed the contributing guidelines of this project as mentioned in [CONTRIBUTING.md](/CONTRIBUTING.md) - [x] I have created an [issue](https://github.com/cloudinary-community/next-cloudinary/issues) ticket for this PR - [x] I have checked to ensure there aren't other open [Pull Requests](https://github.com/cloudinary-community/next-cloudinary/pulls) for the same update/change? - [x] I have performed a self-review of my own code - [x] I have run tests locally to ensure they all pass - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes needed to the documentation BREAKING CHANGE: New build tool, no longer requires `use client` directive, marking as breaking for safety
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Feature Request
Is your feature request related to a problem? Please describe.
Re-introduce subpaths in next Major to allow appending use client directive to components and more targeted imports
#387
#371
#389
#393
The text was updated successfully, but these errors were encountered: