From ad8e523a0988aa685181354fe7d6a78934ee3c16 Mon Sep 17 00:00:00 2001 From: Johannes Schnatterer Date: Thu, 2 May 2024 11:45:05 +0200 Subject: [PATCH] Maven: add tests for settings.xml MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Actually, SonarQube told us we were 0.4% low on test coverage 😅 But it was right: Testing if the settingsXml is only set when using repos or mirrors should have been done. Co-authored-by: Yannick Christian Thomas --- test/com/cloudogu/ces/cesbuildlib/MavenTest.groovy | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/test/com/cloudogu/ces/cesbuildlib/MavenTest.groovy b/test/com/cloudogu/ces/cesbuildlib/MavenTest.groovy index 84a82f9..76880ad 100644 --- a/test/com/cloudogu/ces/cesbuildlib/MavenTest.groovy +++ b/test/com/cloudogu/ces/cesbuildlib/MavenTest.groovy @@ -36,11 +36,20 @@ class MavenTest { def result = mvn "test" assertEquals("test", result) } + + @Test + void testWithoutSettingsXml() throws Exception { + def result = mvn "test" + assert !(mvn.createCommandLineArgs ('dont care')).contains('settings.xml') + assertEquals("test", result) + } @Test void testCallWithMirrors() throws Exception { mvn.useMirrors([name: 'n1', mirrorOf: 'm1', url: 'u1'], [name: 'n2', mirrorOf: 'm2', url: 'u2']) + + assert (mvn.createCommandLineArgs ('dont care')).contains('settings.xml') def result = mvn "test" @@ -58,7 +67,7 @@ class MavenTest { assert actualSettingsXml.contains(expectedXml) } } - + @Test void testCallWithCredentials() throws Exception { mvn.useRepositoryCredentials([id: 'id', credentialsId: 'creds']) @@ -310,6 +319,8 @@ class MavenTest { mvn.useRepositoryCredentials(repos.toArray(new Map[0])) methodUnderTest.call() + + assert (mvn.createCommandLineArgs ('dont care')).contains('settings.xml') def repoIds = [] for (int i = 0; i < repos.size(); i++) {