Issue-122/Values expect list of strings vs string

[carterdanko-dw]

what

Updating the sqs iam permissions, as the values expects to be a list of strings vs just the single string arn that is the output of the module.

why

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/iam_policy_document#condition-1 expects to be a list of strings, vs just the single string arn of the s3 bucket.

references

Github issue #122

[Gowiem]

@carterdanko-dw this looks solid and we're happy to accept the patch -- one question before we do: Can you do some research on if this is due to an AWS provider versioning change? As in in 4.x AWS Provider, this was fine and was working well for folks, but in 5.x AWS provider they're now enforcing this be a list? I assume that is why this was the way it was before... and I want to confirm as we may want to change the provider pins to accommodate.

Appreciate it -- Thanks!

[Gowiem]

/terratest

[carterdanko-dw]

@carterdanko-dw this looks solid and we're happy to accept the patch -- one question before we do: Can you do some research on if this is due to an AWS provider versioning change? As in in 4.x AWS Provider, this was fine and was working well for folks, but in 5.x AWS provider they're now enforcing this be a list? I assume that is why this was the way it was before... and I want to confirm as we may want to change the provider pins to accommodate.

Appreciate it -- Thanks!

Ahh yep let me take a look and compare

[carterdanko-dw]

Tried to modify our versions, Previously we had version = ">= 4.9.0" set, but modified that to just use version 4.x instead of pulling in 5.91.0 that we were pulling in and still got the same error.

provider "registry.opentofu.org/hashicorp/aws" {
  version     = "4.9.0"
  constraints = ">= 2.0.0, >= 3.0.0, >= 4.9.0, ~> 4.9.0"
...

provider "registry.opentofu.org/hashicorp/aws" {
  version     = "5.91.0"
  constraints = ">= 2.0.0, >= 3.0.0, >= 4.9.0"
...

[carterdanko-dw]

Just checking back @Gowiem but it looks like at least from my local testing, things were still failing? Could be a PEBCAK though as well with the 4.x version not working and this is just a 5.x issue.

From the docs on the provider, there is no real change related to this, but I haven't looked through the release notes or anything explicitly.

[goruha]

/terratest

[github-actions]

These changes were released in v1.4.4.