Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There may be a memory leak #30

Open
summer-boythink opened this issue Oct 9, 2024 · 5 comments
Open

There may be a memory leak #30

summer-boythink opened this issue Oct 9, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@summer-boythink
Copy link

When I run ./vendor/bin/phpunit, although the final result of test is OK, it takes 30min to run the result.

There may be a memory leak ?

image

Here is my development environment

image
image

@cclilshy
Copy link
Member

cclilshy commented Oct 9, 2024

Can you confirm which process takes longer to execute? This is most likely because some of the built-in urls in HttpTest have relatively high latency relative to your network environment

@summer-boythink
Copy link
Author

@cclilshy Thank you for your reply. I tried test again, and this time I found the part of test that was blocked

image

@summer-boythink
Copy link
Author

I try to solve it myself first, it seems that wait() is waiting forever

@cclilshy
Copy link
Member

cclilshy commented Oct 9, 2024

I noticed that I had a number of commits today that included changes to $stream->write, and I recommend pulling the latest code again

As for the \Co\wait method, it will wait for all events to finish, including $stream->onReadable events that have not been canceled.

Thanks for your feedback, it is very helpful for this project, and I will pay special attention to this phenomenon happening in 'SocketTest'

In addition, if you have new findings, welcome to feedback with me

@cclilshy
Copy link
Member

cclilshy commented Oct 9, 2024

the purpose of this test is to check whether ripple can guarantee write integrity when the data is larger than the buffer, which may be related to the size of your socket buffer:

Smaller buffers take longer

If the final results of this test pass, you can trust ripple to work properly

@cclilshy cclilshy added the bug Something isn't working label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants