Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

自定义 workspace common 名称 #358

Closed
junhaideng opened this issue Feb 16, 2024 · 1 comment
Closed

自定义 workspace common 名称 #358

junhaideng opened this issue Feb 16, 2024 · 1 comment
Assignees
@Millione
Labels
A-volo-build This issue concerns the `volo-build` crate. C-feature-request This is a feature request issue. Implementations of feature requests use `C-enhancement` instead.

Comments

@junhaideng
Copy link
Contributor

Feature Request

使用 workspace 模式生成的多个 crate，其中有一个公用的，默认名为 common，把不同的 idl 仓库生成的放在一块，如果都是 common 这个名字，有些 crate 索引不到。

如果放在本地通过 path 引用会直接报错

error: package collision in the lockfile: packages common v0.1.0

Crates

  • volo-build
  • pilota-build

Motivation

不同仓库生成的代码，放在一个 git 仓库中供外部访问

Proposal

volo.workspace.yml 中添加一个新的配置字段，eg: common_crate_name，默认值为 "common"，支持自定义

Alternatives
@junhaideng junhaideng changed the title 使用 workspace 模式生成的多个 crate，其中有一个公用的，默认名为 common，把不同的 idl 仓库生成的放在一块，如果都是 common 这个名字，有些 crate 索引不到 自定义 workspace common 名称 Feb 16, 2024
@PureWhiteWu PureWhiteWu added A-volo-build This issue concerns the `volo-build` crate. C-feature-request This is a feature request issue. Implementations of feature requests use `C-enhancement` instead. labels Feb 16, 2024
This was referenced Feb 16, 2024
Merged
Merged
@junhaideng
Copy link
Contributor Author

提交了两个 pr，可能还需要 bump 一下 version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Millione Millione

Labels
A-volo-build This issue concerns the `volo-build` crate. C-feature-request This is a feature request issue. Implementations of feature requests use `C-enhancement` instead.
Milestone
No milestone
Development

No branches or pull requests
3 participants
@PureWhiteWu @Millione @junhaideng