v0.8.1: Add basic libary support for NodeJS #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No transport is working under nodejs. For via-kubectl-raw, I think I'm being made to switch from Deno.Command API to `node:child_process` API in all cases, so giving up the nicer Deno API surface. For via-kubeconfig, I don't see a good path to do server certificates under nodejs. I'm just calling fetch() and on nodejs one must use `import "undici";` to get the certificate trusting logic.
NodeJS can't natively run it with its basic type stripping Maybe not a problem given that we'd publish to JSR which would do the better type conversion. Could revert after nodejs is in a good place.
danopia
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For each client:
InClusterneeds environment variableNODE_EXTRA_CA_CERTS=/var/run/secrets/kubernetes.io/serviceaccount/ca.crt.npm:undici.deno.jsoneither.KubectlRawneeds to be ported fromDeno.Commandtonode:child_processwhich I don't really want to do 😒KubeConfighas similar constraints asInClusterKubectlProxyseems to work fine.