Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor preferences screen to dialog #304

Closed
cloverich opened this issue Jan 25, 2025 · 0 comments · Fixed by #306
Closed

Refactor preferences screen to dialog #304

cloverich opened this issue Jan 25, 2025 · 0 comments · Fixed by #306

Comments

@cloverich
Copy link
Owner

Should be straight forward after #303
cloverich added a commit that referenced this issue Jan 29, 2025
@cloverich
migrate preferences to modal Dialog
606c96c 
- migrate preferences screen from a dedicated route to a modal Dialog, typical of most desktop applications
- add Button, Alert, Label components; refactor Dialog and Select
- re-work journals / app loader to more general global application state

Closes #304
Part of #215
@cloverich cloverich mentioned this issue Jan 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

migrate preferences to modal Dialog cloverich/chronicles
1 participant
@cloverich