Allow recipient registry owner to add recipients for simple recipient registry type #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the first 3 items in #510
@auryn-macmillan , please review the changes and let me know if the registration flow is acceptable because for simple registry, once owner added the recipient, it automatically shows up, no need to go to the /recipients page to accept the recipient. Also, the UI currently doesn't support deleting a recipient from the simple registry atm.
Also, should we revise the content for
/about/recipientsince it's applicable to the optimistic registry only? I did attempt to remove the optimistic wording in this PR which will be deprecated in favour of this PR.