Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maybe implement manually created links detection with a TextFormatter tag filter #29

Open
n-peugnet opened this issue Feb 13, 2023 · 0 comments
Open

Maybe implement manually created links detection with a TextFormatter tag filter #29

n-peugnet opened this issue Feb 13, 2023 · 0 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@n-peugnet
Copy link
Member

n-peugnet commented Feb 13, 2023 •
edited
Loading

Same as #27, but at parsing time. See: https://s9etextformatter.readthedocs.io/Filters/Tag_filters/

This way we can detect that a links points to a discussion from the parsing step. This would allow to:

  1. limit the parsing logic code to a single place: Formatter\CrossReferencesConfigurator.php
  2. make this information available in JavaScript
  3. Simplify the PostEventListener logic.
@n-peugnet n-peugnet added enhancement New feature or request question Further information is requested labels Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@n-peugnet