Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Fill Descriptions Methods for L1T Producers #63

Open
mulhearn opened this issue Oct 17, 2015 · 4 comments
Open

Update Fill Descriptions Methods for L1T Producers #63

mulhearn opened this issue Oct 17, 2015 · 4 comments
Assignees
Labels

Comments

@mulhearn
Copy link
Member

@z4027163 you are the point man for this desk.

We need to update the fillDescriptions methods throughout L1T modules so that we get sensible debugging output when parameters are left unset by users.

@mulhearn
Copy link
Member Author

Start with these violators:
mulhearn@lxplus0047>grep setUnknown L1Trigger/L1TCalorimeter/plugins/*
L1Trigger/L1TCalorimeter/plugins/L1TCaloRCTToUpgradeConverter.cc: desc.setUnknown();
L1Trigger/L1TCalorimeter/plugins/L1TCaloStage1LutWriter.cc: desc.setUnknown();
L1Trigger/L1TCalorimeter/plugins/L1TPhysicalEtAdder.cc: desc.setUnknown();
L1Trigger/L1TCalorimeter/plugins/L1TStage1Layer2Producer.cc: desc.setUnknown();
L1Trigger/L1TCalorimeter/plugins/L1TStage2CaloAnalyzer.cc: desc.setUnknown();
L1Trigger/L1TCalorimeter/plugins/L1TStage2InputPatternWriter.cc: desc.setUnknown();
L1Trigger/L1TCalorimeter/plugins/L1TStage2Layer1Producer.cc: desc.setUnknown();
L1Trigger/L1TCalorimeter/plugins/L1TStage2Layer2Producer.cc: desc.setUnknown();

@z4027163
Copy link

@mulhearn Got it

@z4027163
Copy link

@z4027163
Copy link

What does the second half in the brace mean when I add the description?
Like
desc.addedm::InputTag("InputCollection",edm::InputTag("caloStage1Digis"));
desc.addedm::InputTag("InputRlxTauCollection",edm::InputTag("caloStage1Digis:rlxTaus"));

Does that mean the default value? Is there any requirement on the name? Or any name I come up with?

Also for std::string, do I set 0 to be the second half in the brace? like
desc.addstd::string("conditionsLabel",0);

@mulhearn mulhearn added the Todo label Nov 12, 2015
@mulhearn mulhearn changed the title [TODO] Update Fill Descriptions Methods for L1T Producers Update Fill Descriptions Methods for L1T Producers Nov 12, 2015
rekovic pushed a commit that referenced this issue Feb 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants