Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated FG bit definition #79

Open
mulhearn opened this issue Nov 3, 2015 · 5 comments
Open

Updated FG bit definition #79

mulhearn opened this issue Nov 3, 2015 · 5 comments

Comments

@mulhearn
Copy link
Member

mulhearn commented Nov 3, 2015

Tracking PRs:

@mulhearn
Copy link
Member Author

mulhearn commented Nov 3, 2015

@mnorthup6690 can you make an 80X PR in addition to the 76X one?

@mulhearn mulhearn added the URGENT label Nov 3, 2015
@mulhearn
Copy link
Member Author

mulhearn commented Nov 5, 2015

@mnorthup6690: can you please make the PR for 80X, then we can argue that this is needed urgently in 75X for HI running... meanwhile, I sign the 75X PR.

@mnorthup6690
Copy link

Hello Mike. You can find the PR for 80X here cms-sw#12276

@mulhearn mulhearn changed the title [PR Tracking] Updated FG bit definition Updated FG bit definition Nov 12, 2015
@mulhearn
Copy link
Member Author

Grrrr, it looks like this didn't make it into 80X yet, and now that branch doesn't merge.

We should get this in for close of 80X next week.

It looks like this got hung up over an unneeded ROOT include header. What a nightmare!

@mnorthup6690 if you don't know how to rebase (again!) this branch cms-l1t-offline:pr-update-fg-bit-80x then I will do it.

@mulhearn
Copy link
Member Author

mulhearn commented Feb 6, 2016

@mnorthup6690 I tried to rebase this but there are non-trivial conflicts... can you have a look? Or do we simply abandon this as unneeded?

cbbrainerd pushed a commit that referenced this issue Mar 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants