-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Special CMSSW_14_2 ROOT633 release for RNTuple #46415
Comments
assign orp |
New categories assigned: orp @antoniovilela,@mandrenguyen,@rappoccio,@sextonkennedy you have been requested to review this Pull request/Issue and eventually sign? Thanks |
cms-bot internal usage |
A new Issue was created by @smuzaffar. @Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
@makortel and I double checked and the commits we need are in that version of the ROOT branch. |
@antoniovilela, @mandrenguyen let me know if I can start this build |
yes, sure |
thanks @antoniovilela , I have opened #46424 |
The most recent required fix in ROOT's master branch is now available |
@Dr15Jones , root-project/root#16712 is now available in our ROOT6 IB (CMSSW_14_2_ROOT6_X_2024-10-20-2300 and above). |
I can confirm that our version of ROOT now does have the needed fix for reading back RNTuple code. I'll do a few more tests to be confident we can make a special release. |
@smuzaffar I have tried reading back an RNTuple file in the new release and it seems to work just fine. With that, I think we are clear to create the special release based on our most recent ROOT6 IBs. |
@Dr15Jones , as 14.2.0.pre3 is scheduled for this week, so may be we should wait few more days and then build CMSSW_14_2_0_pre3_ROOT633 |
I agree that waiting for pre3 makes sense. Thanks. |
Even though the latest version of ROOT master didn't solve my read-back problem, I think we should go ahead with the CMSSW_14_2_0_pre3_ROOT633. |
I guess this issue could be closed now? |
We have not built this release yet. @Dr15Jones wanted root-project/root#16810 to be part of stable release and this was only included in last night (2024-11-12-2300) IB ROOT6. As 14.2.0.pre4 is schedule for this week so I will wait for pre4 and then build a stable ROOT635 release based on pre4 |
@Dr15Jones , 14.2.0.pre4 is in build phase. Should we start building 14_2_0_pre2_ROOT635 (root master is root 6.35 now) as a stable release for RNTuple studies or are we still missing something from root in our ROOT6 which should go in this special release? |
@smuzaffar I am not aware of any very recent RNTuple that we need. |
So should we build 14_2_0_pre2_ROOT635 or ROOT6 IBs are good enough for now? |
A 14_2_0_pre4_ROOT635 would be very helpful. |
started via #46745 |
closing this issue as CMSSW_14_2_0_pre4_ROOT635 is available now |
@cms-sw/orp-l2 , @cms-sw/core-l2 would like to build a special CMSSW_14_2 ROOT633 release measure the properties of RNTuple. The changes needed for this have been integrated in CMSSW_14_2_ROOT6_X IBs. We propose to build
CMSSW_14_2_0_pre2_50ecb2c_ROOT633
which should useIf no objections then I can open the build issue to start building the release for
el8_amd64_gcc12
arch only.The text was updated successfully, but these errors were encountered: