Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special CMSSW_14_2 ROOT633 release for RNTuple #46415

Closed
smuzaffar opened this issue Oct 17, 2024 · 23 comments
Closed

Special CMSSW_14_2 ROOT633 release for RNTuple #46415

smuzaffar opened this issue Oct 17, 2024 · 23 comments

Comments

@smuzaffar
Copy link
Contributor

@cms-sw/orp-l2 , @cms-sw/core-l2 would like to build a special CMSSW_14_2 ROOT633 release measure the properties of RNTuple. The changes needed for this have been integrated in CMSSW_14_2_ROOT6_X IBs. We propose to build CMSSW_14_2_0_pre2_50ecb2c_ROOT633 which should use

  • CMSSW tag CMSSW_14_2_ROOT6_X_2024-10-16-2300 or commit 50ecb2c
  • Latest IB/CMSSW_14_2_0/rootmaster cmsdist changes

If no objections then I can open the build issue to start building the release for el8_amd64_gcc12 arch only.

@smuzaffar
Copy link
Contributor Author

assign orp

@cmsbuild
Copy link
Contributor

New categories assigned: orp

@antoniovilela,@mandrenguyen,@rappoccio,@sextonkennedy you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

cms-bot internal usage

@cmsbuild
Copy link
Contributor

A new Issue was created by @smuzaffar.

@Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor

@makortel and I double checked and the commits we need are in that version of the ROOT branch.

@smuzaffar
Copy link
Contributor Author

@antoniovilela, @mandrenguyen let me know if I can start this build

@antoniovilela
Copy link
Contributor

@antoniovilela, @mandrenguyen let me know if I can start this build

yes, sure

@smuzaffar
Copy link
Contributor Author

thanks @antoniovilela , I have opened #46424

@Dr15Jones
Copy link
Contributor

The most recent required fix in ROOT's master branch is now available

root-project/root#16712

@smuzaffar
Copy link
Contributor Author

@Dr15Jones , root-project/root#16712 is now available in our ROOT6 IB (CMSSW_14_2_ROOT6_X_2024-10-20-2300 and above).

@Dr15Jones
Copy link
Contributor

I can confirm that our version of ROOT now does have the needed fix for reading back RNTuple code. I'll do a few more tests to be confident we can make a special release.

@Dr15Jones
Copy link
Contributor

@smuzaffar I have tried reading back an RNTuple file in the new release and it seems to work just fine. With that, I think we are clear to create the special release based on our most recent ROOT6 IBs.

@smuzaffar
Copy link
Contributor Author

@Dr15Jones , as 14.2.0.pre3 is scheduled for this week, so may be we should wait few more days and then build CMSSW_14_2_0_pre3_ROOT633

@Dr15Jones
Copy link
Contributor

I agree that waiting for pre3 makes sense. Thanks.

@Dr15Jones
Copy link
Contributor

Even though the latest version of ROOT master didn't solve my read-back problem, I think we should go ahead with the CMSSW_14_2_0_pre3_ROOT633.

@makortel
Copy link
Contributor

I guess this issue could be closed now?

@smuzaffar
Copy link
Contributor Author

We have not built this release yet. @Dr15Jones wanted root-project/root#16810 to be part of stable release and this was only included in last night (2024-11-12-2300) IB ROOT6. As 14.2.0.pre4 is schedule for this week so I will wait for pre4 and then build a stable ROOT635 release based on pre4

@smuzaffar
Copy link
Contributor Author

smuzaffar commented Nov 20, 2024

@Dr15Jones , 14.2.0.pre4 is in build phase. Should we start building 14_2_0_pre2_ROOT635 (root master is root 6.35 now) as a stable release for RNTuple studies or are we still missing something from root in our ROOT6 which should go in this special release?

@Dr15Jones
Copy link
Contributor

@smuzaffar I am not aware of any very recent RNTuple that we need.

@smuzaffar
Copy link
Contributor Author

So should we build 14_2_0_pre2_ROOT635 or ROOT6 IBs are good enough for now?

@Dr15Jones
Copy link
Contributor

A 14_2_0_pre4_ROOT635 would be very helpful.

@smuzaffar
Copy link
Contributor Author

started via #46745

@smuzaffar
Copy link
Contributor Author

closing this issue as CMSSW_14_2_0_pre4_ROOT635 is available now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants