Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROCM_X] Multiple RelVals failing in ROCM_X IB #46624

Open
iarspider opened this issue Nov 7, 2024 · 22 comments
Open

[ROCM_X] Multiple RelVals failing in ROCM_X IB #46624

iarspider opened this issue Nov 7, 2024 · 22 comments

Comments

@iarspider
Copy link
Contributor

In CMSSW_14_2_ROCM_X_2024-11-06-2300 we observe multiple Unit test and RelVal failures:

What failed Description
DataFormats/SoATemplate/testRocmSoALayoutAndView_t HSA_STATUS_ERROR_EXCEPTION: An HSAIL operation resulted in a hardware exception
HeterogeneousCore/AlpakaInterface/alpakaTestBufferROCmAsync HSA_STATUS_ERROR_EXCEPTION: An HSAIL operation resulted in a hardware exception
HeterogeneousCore/AlpakaInterface/alpakaTestPrefixScanROCmAsync Many Device-side assertion '0 == blockDimension % warpSize' failed. followed by HSA_STATUS_ERROR_EXCEPTION
Relval 141.008583 step 2 ModuleTypeResolverAlpaka had no backends available because of the combination of the job configuration and accelerator availability of on the machine. The job sees accelerators
Relval 29834.403 step 2 HSA_STATUS_ERROR_OUT_OF_RESOURCES: The runtime failed to allocate the necessary resources
Relval 29834.404 step 2 StdException
Relval 141.008507 step 3 ModuleTypeResolverAlpaka had no backends available because of the combination of the job configuration and accelerator availability of on the machine. The job sees accelerators
Relval 141.008508 step 3 Fatal exception: Unable to choose current device because CUDAService is not preset or disabled. If CUDAService was not explicitly disabled in the configuration, the probable cause is that there is no GPU or there is some problem in the CUDA runtime or drivers.
Relval 141.008513 step 3 ModuleTypeResolverAlpaka had no backends available because of the combination of the job configuration and accelerator availability of on the machine. The job sees accelerators
Relval 141.008514 step 3 BadAlloc
Relval 141.008523 step 3 ModuleTypeResolverAlpaka had no backends available because of the combination of the job configuration and accelerator availability of on the machine. The job sees accelerators
Relval 141.008524 step 3 BadAlloc
Relval 12834.402 step 3 SIGSEGV in roc::DmaBlitManager::hsaCopyStaged
Relval 13034.402 step 3 SIGABRT
Relval 13034.404 step 3 SIGABRT
Relval 13034.406 step 3 SIGABRT
Relval 13034.408 step 3 SIGABRT
Relval 13050.402 step 3 SIGABRT
Relval 13050.404 step 3 SIGABRT
Relval 13050.406 step 3 SIGSEGV in roc::DmaBlitManager::hsaCopyStaged
Relval 13050.408 step 3 SIGABRT
Relval 13061.402 step 3 SIGSEGV in roc::DmaBlitManager::hsaCopyStaged
Relval 29634.402 step 3 SIGABRT
Relval 29834.402 step 3 SIGABRT
Relval 160.03502 step 4 BadAlloc

(SIGABRTs are either HSA_STATUS_ERROR_EXCEPTION: An HSAIL operation resulted in a hardware exception or HSA_STATUS_ERROR_OUT_OF_RESOURCES: The runtime failed to allocate the necessary resources

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2024

A new Issue was created by @iarspider.

@Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@aandvalenzuela
Copy link
Contributor

RelVal 160.03502 should be disabled for ROCM IBs since it is a CUDA-only workflow.

@makortel
Copy link
Contributor

makortel commented Nov 7, 2024

assign heterogeneous

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2024

New categories assigned: heterogeneous

@fwyzard,@makortel you have been requested to review this Pull request/Issue and eventually sign? Thanks

@fwyzard
Copy link
Contributor

fwyzard commented Nov 7, 2024

DataFormats/SoATemplate/testRocmSoALayoutAndView_t

This is actually the expected behaviour, well, kind of.

The test causes an error on the GPU and tries to report that. However for the HIP/ROCm runtime the GPU-side error or "hardware exception" results in a crash/abort of the CPU-side application.

So, we want the test to fail, maybe not this badly ?

@fwyzard
Copy link
Contributor

fwyzard commented Nov 7, 2024

HeterogeneousCore/AlpakaInterface/alpakaTestBufferROCmAsync

This is the same as #46624 (comment) .

@fwyzard
Copy link
Contributor

fwyzard commented Nov 7, 2024

HeterogeneousCore/AlpakaInterface/alpakaTestPrefixScanROCmAsync

I'm investigating this together with @AuroraPerego .
It seems a problem with the test itself rather than with the functionality being tested, I should have a fix soon.

@fwyzard
Copy link
Contributor

fwyzard commented Nov 7, 2024

Relval 141.008583 step 2

This is currently implemented as a CUDA-only workflow ('--accelerators': 'gpu-nvidia').

@AdrianoDee do you know if this uses the alpaka version of the modules (then it could be changed to use '--accelerators': 'gpu-*') or the cuda version (then it should be disabled for the AMD tests) ?

@fwyzard
Copy link
Contributor

fwyzard commented Nov 7, 2024

In fact, I think all

Relval 141.0085xx step 3

workflows are CUDA-only and should not be run for the AMD GPU tests.

@fwyzard
Copy link
Contributor

fwyzard commented Nov 7, 2024

When possible I'll start looking at the *.40x workflows.

@AdrianoDee
Copy link
Contributor

Yes, all these are data RelVals using the old CUDA setup.

@AdrianoDee
Copy link
Contributor

All the 141.* + 160.*

@makortel
Copy link
Contributor

makortel commented Nov 7, 2024

DataFormats/SoATemplate/testRocmSoALayoutAndView_t

This is actually the expected behaviour, well, kind of.

The test causes an error on the GPU and tries to report that. However for the HIP/ROCm runtime the GPU-side error or "hardware exception" results in a crash/abort of the CPU-side application.

So, we want the test to fail, maybe not this badly ?

Yeah, turning the error into an exception (that could be checked in the test itself) would be highly desirable.

@fwyzard
Copy link
Contributor

fwyzard commented Nov 7, 2024

Yeah, turning the error into an exception (that could be checked in the test itself) would be highly desirable.

As far as I have been able to find out, that would require making changes to the HSA and ROCm runtime.

@fwyzard
Copy link
Contributor

fwyzard commented Nov 7, 2024

HeterogeneousCore/AlpakaInterface/alpakaTestPrefixScanROCmAsync

Fixed by #46629 .

@fwyzard
Copy link
Contributor

fwyzard commented Nov 8, 2024

Relval 29834.404 step 2

I'm trying to run this workflow by hand on a LUMI node with

runTheMatrix.py -w gpu -l 29834.404

but it fails already during step 1, with

----- Begin Fatal Exception 08-Nov-2024 09:58:07 EET-----------------------
An exception of category 'Configuration' occurred while
   [0] Processing global begin LuminosityBlock run: 1 luminosityBlock: 1
   [1] Calling method for module Pythia8ConcurrentGeneratorFilter/'generator'
Exception Message:
Failed to initialize hadronizer Pythia8Hadronizer for internal parton generation
----- End Fatal Exception -------------------------------------------------

Do I need some other options to run ?

@fwyzard
Copy link
Contributor

fwyzard commented Nov 8, 2024

And, on a local machine at CERN, it passes step1 but fails step2 with

----- Begin Fatal Exception 08-Nov-2024 09:04:28 CET-----------------------
An exception of category 'NoSecondaryFiles' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
RootEmbeddedFileSequence no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

Suggestions ?

@AdrianoDee
Copy link
Contributor

AdrianoDee commented Nov 8, 2024

And, on a local machine at CERN, it passes step1 but fails step2 with

----- Begin Fatal Exception 08-Nov-2024 09:04:28 CET-----------------------
An exception of category 'NoSecondaryFiles' occurred while
[0] Constructing the EventProcessor
[1] Constructing module: class=MixingModule label='mix'
Exception Message:
RootEmbeddedFileSequence no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------
Suggestions ?

Seems cmsDriver can't get the MinBias input files. Could it be a problem of certificate?
(I've tested it locally and step2 runs)

@fwyzard
Copy link
Contributor

fwyzard commented Nov 8, 2024

Thanks, re-running cmsDriver after the right gird setup seems to have worked for this.

@fwyzard
Copy link
Contributor

fwyzard commented Nov 10, 2024

Relval 29834.404 step 2

After setting up CVMFS and the Grid tools on LUMI this works for me with pre3:

29834.404_TTbar_14TeV+2026D110PU_Patatrack_PixelOnlyAlpaka_Profiling Step0-PASSED Step1-PASSED Step2-PASSED - time date Sun Nov 10 07:34:10 2024-date Sun Nov 10 07:05:15 2024; exit: 0 0 0
1 1 1 tests passed, 0 0 0 failed

Edit no, wait, it's running CPU-only...

@fwyzard
Copy link
Contributor

fwyzard commented Nov 10, 2024

OK, it does work:

$ cmsRun step2_DIGI_L1TrackTrigger_L1_L1P2GT_DIGI2RAW_HLT_PU.py |& tee step2.log
%MSG-i AlpakaService:  (NoModuleName) 10-Nov-2024 10:46:38 EET pre-events
AlpakaServiceSerialSync succesfully initialised.
Found 1 device:
  - AMD EPYC 7A53 64-Core Processor
%MSG
%MSG-i ROCmService:  (NoModuleName) 10-Nov-2024 10:46:38 EET pre-events
ROCm runtime version 5.6.31062, driver version 5.6.31062, AMD driver version 6.3.6
ROCm device 0: AMD Instinct MI250X (gfx90a:sramecc+:xnack-)
%MSG
%MSG-i AlpakaService:  (NoModuleName) 10-Nov-2024 10:46:39 EET pre-events
AlpakaServiceROCmAsync succesfully initialised.
Found 1 device:
  - AMD Instinct MI250X
%MSG
10-Nov-2024 10:47:20 EET  Initiating request to open file file:step1.root
10-Nov-2024 10:47:21 EET  Successfully opened file file:step1.root
10-Nov-2024 10:47:40 EET  Initiating request to open file root://hip-cms-se.csc.fi:1094//store/relval/CMSSW_14_1_0_pre5/RelValMinBias_14TeV/GEN-SIM/140X_mcRun4_realistic_v4_RegeneratedGS_2026D110_noPU-v1/2580000/0dfa017f-9854-4ba1-a780-e8cb02f9cac1.root
...
Begin processing the 1st record. Run 1, Event 1, LumiSection 1 on stream 0 at 10-Nov-2024 10:49:52.693 EET
...
Begin processing the 10th record. Run 1, Event 10, LumiSection 1 on stream 0 at 10-Nov-2024 10:59:12.452 EET
...
10-Nov-2024 11:00:06 EET  Closed file file:step1.root
10-Nov-2024 11:00:07 EET  Closed file root://xrootd-cms.infn.it//store/relval/CMSSW_14_1_0_pre5/RelValMinBias_14TeV/GEN-SIM/140X_mcRun4_realistic_v4_RegeneratedGS_2026D110_noPU-v1/2580000/0dfa017f-9854-4ba1-a780-e8cb02f9cac1.root

$ echo $?
0

We'll have to double check the cmsbuild environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants