Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditional jump or move depends on uninitialized variable in SiPixelDigitizerAlgorithm::add_noise() #46759

Open
makortel opened this issue Nov 21, 2024 · 7 comments
Open

Conditional jump or move depends on uninitialized variable in SiPixelDigitizerAlgorithm::add_noise() #46759

makortel opened this issue Nov 21, 2024 · 7 comments
Labels
pending-signatures simulation-pending trk

Comments

@makortel
Copy link
Contributor

From #42564 (comment)
Valgrind on workflow 250202.5 step 2 reports

==3506566== Conditional jump or move depends on uninitialised value(s)
==3506566==    at 0x55237B54: SiPixelDigitizerAlgorithm::add_noise(PixelGeomDetUnit const*, float, CLHEP::HepRandomEngine*) (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/lib/el8_amd64_gcc12/pluginSimTrackerSiPixelDigitizerPlugins.so)
==3506566==    by 0x5522DF4C: SiPixelDigitizerAlgorithm::digitize(PixelGeomDetUnit const*, std::vector<PixelDigi, std::allocator<PixelDigi> >&, std::vector<PixelDigiSimLink, std::allocator<PixelDigiSimLink> >&, std::vector<PixelDigiAddTempInfo, std::allocator<PixelDigiAddTempInfo> >&, TrackerTopology const*, CLHEP::HepRandomEngine*) (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/lib/el8_amd64_gcc12/pluginSimTrackerSiPixelDigitizerPlugins.so)
==3506566==    by 0x5521B3DB: cms::SiPixelDigitizer::finalizeEvent(edm::Event&, edm::EventSetup const&) (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/lib/el8_amd64_gcc12/pluginSimTrackerSiPixelDigitizerPlugins.so)
==3506566==    by 0x49737BCA: edm::MixingModule::finalizeEvent(edm::Event&, edm::EventSetup const&) (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/lib/el8_amd64_gcc12/pluginSimGeneralMixingModulePlugins.so)
==3506566==    by 0x497A0D10: edm::BMixingModule::produce(edm::Event&, edm::EventSetup const&) (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/lib/el8_amd64_gcc12/libMixingBase.so)
==3506566==    by 0x4C88FC2: edm::stream::EDProducerAdaptorBase::doEvent(edm::EventTransitionInfo const&, edm::ActivityRegistry*, edm::ModuleCallingContext const*) (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/lib/el8_amd64_gcc12/libFWCoreFramework.so)
==3506566==    by 0x4C7053B: edm::WorkerT<edm::stream::EDProducerAdaptorBase>::implDo(edm::EventTransitionInfo const&, edm::ModuleCallingContext const*) (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/lib/el8_amd64_gcc12/libFWCoreFramework.so)
==3506566==    by 0x4BF4CF8: std::__exception_ptr::exception_ptr edm::Worker::runModuleAfterAsyncPrefetch<edm::OccurrenceTraits<edm::EventPrincipal, (edm::BranchActionType)1> >(std::__exception_ptr::exception_ptr, edm::OccurrenceTraits<edm::EventPrincipal, (edm::BranchActionType)1>::TransitionInfoType const&, edm::StreamID, edm::ParentContext const&, edm::OccurrenceTraits<edm::EventPrincipal, (edm::BranchActionType)1>::Context const*) (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/lib/el8_amd64_gcc12/libFWCoreFramework.so)
==3506566==    by 0x4BF51F0: edm::Worker::RunModuleTask<edm::OccurrenceTraits<edm::EventPrincipal, (edm::BranchActionType)1> >::execute() (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/lib/el8_amd64_gcc12/libFWCoreFramework.so)
==3506566==    by 0x421B237: tbb::detail::d1::function_task<edm::WaitingTaskList::announce()::{lambda()#1}>::execute(tbb::detail::d1::execution_data&) (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/lib/el8_amd64_gcc12/libFWCoreConcurrency.so)
==3506566==    by 0x64553E0: UnknownInlinedFun (task_dispatcher.h:322)
==3506566==    by 0x64553E0: UnknownInlinedFun (task_dispatcher.h:458)
==3506566==    by 0x64553E0: tbb::detail::r1::task_dispatcher::execute_and_wait(tbb::detail::d1::task*, tbb::detail::d1::wait_context&, tbb::detail::d1::task_group_context&) (task_dispatcher.cpp:168)
==3506566==    by 0x4B7539A: edm::FinalWaitingTask::wait() (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/lib/el8_amd64_gcc12/libFWCoreFramework.so)
==3506566==    by 0x4B82E2E: edm::EventProcessor::processRuns() (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/lib/el8_amd64_gcc12/libFWCoreFramework.so)
==3506566==    by 0x4B832E0: edm::EventProcessor::runToCompletion() (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/lib/el8_amd64_gcc12/libFWCoreFramework.so)
==3506566==    by 0x40840B: tbb::detail::d1::task_arena_function<main::{lambda()#1}::operator()() const::{lambda()#1}, void>::operator()() const (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/bin/el8_amd64_gcc12/cmsRun)
==3506566==    by 0x64419AC: tbb::detail::r1::task_arena_impl::execute(tbb::detail::d1::task_arena_base&, tbb::detail::d1::delegate_base&) (arena.cpp:688)
==3506566==    by 0x40A0F1: main::{lambda()#1}::operator()() const (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/bin/el8_amd64_gcc12/cmsRun)
==3506566==    by 0x4050FF: main (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/bin/el8_amd64_gcc12/cmsRun)
==3506566==  Uninitialised value was created by a heap allocation
==3506566==    at 0x403BEE1: operator new(unsigned long) (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/external/valgrind/3.23.0-143b83b3001a13f5bb2e0a4b5445fed5/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==3506566==    by 0x55237B00: SiPixelDigitizerAlgorithm::add_noise(PixelGeomDetUnit const*, float, CLHEP::HepRandomEngine*) (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/lib/el8_amd64_gcc12/pluginSimTrackerSiPixelDigitizerPlugins.so)
==3506566==    by 0x5522DF4C: SiPixelDigitizerAlgorithm::digitize(PixelGeomDetUnit const*, std::vector<PixelDigi, std::allocator<PixelDigi> >&, std::vector<PixelDigiSimLink, std::allocator<PixelDigiSimLink> >&, std::vector<PixelDigiAddTempInfo, std::allocator<PixelDigiAddTempInfo> >&, TrackerTopology const*, CLHEP::HepRandomEngine*) (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/lib/el8_amd64_gcc12/pluginSimTrackerSiPixelDigitizerPlugins.so)
==3506566==    by 0x5521B3DB: cms::SiPixelDigitizer::finalizeEvent(edm::Event&, edm::EventSetup const&) (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/lib/el8_amd64_gcc12/pluginSimTrackerSiPixelDigitizerPlugins.so)
==3506566==    by 0x49737BCA: edm::MixingModule::finalizeEvent(edm::Event&, edm::EventSetup const&) (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/lib/el8_amd64_gcc12/pluginSimGeneralMixingModulePlugins.so)
==3506566==    by 0x497A0D10: edm::BMixingModule::produce(edm::Event&, edm::EventSetup const&) (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/lib/el8_amd64_gcc12/libMixingBase.so)
==3506566==    by 0x4C88FC2: edm::stream::EDProducerAdaptorBase::doEvent(edm::EventTransitionInfo const&, edm::ActivityRegistry*, edm::ModuleCallingContext const*) (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/lib/el8_amd64_gcc12/libFWCoreFramework.so)
==3506566==    by 0x4C7053B: edm::WorkerT<edm::stream::EDProducerAdaptorBase>::implDo(edm::EventTransitionInfo const&, edm::ModuleCallingContext const*) (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/lib/el8_amd64_gcc12/libFWCoreFramework.so)
==3506566==    by 0x4BF4CF8: std::__exception_ptr::exception_ptr edm::Worker::runModuleAfterAsyncPrefetch<edm::OccurrenceTraits<edm::EventPrincipal, (edm::BranchActionType)1> >(std::__exception_ptr::exception_ptr, edm::OccurrenceTraits<edm::EventPrincipal, (edm::BranchActionType)1>::TransitionInfoType const&, edm::StreamID, edm::ParentContext const&, edm::OccurrenceTraits<edm::EventPrincipal, (edm::BranchActionType)1>::Context const*) (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/lib/el8_amd64_gcc12/libFWCoreFramework.so)
==3506566==    by 0x4BF51F0: edm::Worker::RunModuleTask<edm::OccurrenceTraits<edm::EventPrincipal, (edm::BranchActionType)1> >::execute() (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/lib/el8_amd64_gcc12/libFWCoreFramework.so)
==3506566==    by 0x421B237: tbb::detail::d1::function_task<edm::WaitingTaskList::announce()::{lambda()#1}>::execute(tbb::detail::d1::execution_data&) (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/lib/el8_amd64_gcc12/libFWCoreConcurrency.so)
==3506566==    by 0x64553E0: UnknownInlinedFun (task_dispatcher.h:322)
==3506566==    by 0x64553E0: UnknownInlinedFun (task_dispatcher.h:458)
==3506566==    by 0x64553E0: tbb::detail::r1::task_dispatcher::execute_and_wait(tbb::detail::d1::task*, tbb::detail::d1::wait_context&, tbb::detail::d1::task_group_context&) (task_dispatcher.cpp:168)
==3506566==    by 0x4B7539A: edm::FinalWaitingTask::wait() (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/lib/el8_amd64_gcc12/libFWCoreFramework.so)
==3506566==    by 0x4B82E2E: edm::EventProcessor::processRuns() (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/lib/el8_amd64_gcc12/libFWCoreFramework.so)
==3506566==    by 0x4B832E0: edm::EventProcessor::runToCompletion() (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/lib/el8_amd64_gcc12/libFWCoreFramework.so)
==3506566==    by 0x40840B: tbb::detail::d1::task_arena_function<main::{lambda()#1}::operator()() const::{lambda()#1}, void>::operator()() const (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/bin/el8_amd64_gcc12/cmsRun)
==3506566==    by 0x64419AC: tbb::detail::r1::task_arena_impl::execute(tbb::detail::d1::task_arena_base&, tbb::detail::d1::delegate_base&) (arena.cpp:688)
==3506566==    by 0x40A0F1: main::{lambda()#1}::operator()() const (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/bin/el8_amd64_gcc12/cmsRun)
==3506566==    by 0x4050FF: main (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/bin/el8_amd64_gcc12/cmsRun)
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 21, 2024 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Contributor

A new Issue was created by @makortel.

@Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

assign SimTracker/SiPixelDigitizer

@cmsbuild
Copy link
Contributor

New categories assigned: simulation

@civanch,@kpedro88,@mdhildreth you have been requested to review this Pull request/Issue and eventually sign? Thanks

@makortel
Copy link
Contributor Author

I'll re-run valgrind with debug symbols in SiPixelDigitizerAlgorithm to get line numbers

@makortel
Copy link
Contributor Author

Here is the report with line numbers (on CMSSW_14_2_X_2024-11-18-1100)

==1374585== Conditional jump or move depends on uninitialised value(s)
==1374585==    at 0x5503CB54: UnknownInlinedFun (DigitizerUtility.h:67)
==1374585==    by 0x5503CB54: SiPixelDigitizerAlgorithm::add_noise(PixelGeomDetUnit const*, float, CLHEP::HepRandomEngine*) (SiPixelDigitizerAlgorithm.cc:1829)
==1374585==    by 0x55032F4C: SiPixelDigitizerAlgorithm::digitize(PixelGeomDetUnit const*, std::vector<PixelDigi, std::allocator<PixelDigi> >&, std::vector<PixelDigiSimLink, std::allocator<PixelDigiSimLink> >&, std::vector<PixelDigiAddTempInfo, std::allocator<PixelDigiAddTempInfo> >&, TrackerTopology const*, CLHEP::HepRandomEngine*) (SiPixelDigitizerAlgorithm.cc:1099)
==1374585==    by 0x550203DB: cms::SiPixelDigitizer::finalizeEvent(edm::Event&, edm::EventSetup const&) (SiPixelDigitizer.cc:289)
==1374585==    by 0x49737BCA: edm::MixingModule::finalizeEvent(edm::Event&, edm::EventSetup const&) (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/lib/el8_amd64_gcc12/pluginSimGeneralMixingModulePlugins.so)
==1374585==    by 0x497A0D10: edm::BMixingModule::produce(edm::Event&, edm::EventSetup const&) (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/lib/el8_amd64_gcc12/libMixingBase.so)
==1374585==    by 0x4C88FC2: edm::stream::EDProducerAdaptorBase::doEvent(edm::EventTransitionInfo const&, edm::ActivityRegistry*, edm::ModuleCallingContext const*) (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/lib/el8_amd64_gcc12/libFWCoreFramework.so)
==1374585==    by 0x4C7053B: edm::WorkerT<edm::stream::EDProducerAdaptorBase>::implDo(edm::EventTransitionInfo const&, edm::ModuleCallingContext const*) (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/lib/el8_amd64_gcc12/libFWCoreFramework.so)
==1374585==    by 0x4BF4CF8: std::__exception_ptr::exception_ptr edm::Worker::runModuleAfterAsyncPrefetch<edm::OccurrenceTraits<edm::EventPrincipal, (edm::BranchActionType)1> >(std::__exception_ptr::exception_ptr, edm::OccurrenceTraits<edm::EventPrincipal, (edm::BranchActionType)1>::TransitionInfoType const&, edm::StreamID, edm::ParentContext const&, edm::OccurrenceTraits<edm::EventPrincipal, (edm::BranchActionType)1>::Context const*) (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/lib/el8_amd64_gcc12/libFWCoreFramework.so)
==1374585==    by 0x4BF51F0: edm::Worker::RunModuleTask<edm::OccurrenceTraits<edm::EventPrincipal, (edm::BranchActionType)1> >::execute() (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/lib/el8_amd64_gcc12/libFWCoreFramework.so)
==1374585==    by 0x421B237: tbb::detail::d1::function_task<edm::WaitingTaskList::announce()::{lambda()#1}>::execute(tbb::detail::d1::execution_data&) (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/lib/el8_amd64_gcc12/libFWCoreConcurrency.so)
==1374585==    by 0x64553E0: UnknownInlinedFun (task_dispatcher.h:322)
==1374585==    by 0x64553E0: UnknownInlinedFun (task_dispatcher.h:458)
==1374585==    by 0x64553E0: tbb::detail::r1::task_dispatcher::execute_and_wait(tbb::detail::d1::task*, tbb::detail::d1::wait_context&, tbb::detail::d1::task_group_context&) (task_dispatcher.cpp:168)
==1374585==    by 0x4B7539A: edm::FinalWaitingTask::wait() (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/lib/el8_amd64_gcc12/libFWCoreFramework.so)
==1374585==    by 0x4B82E2E: edm::EventProcessor::processRuns() (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/lib/el8_amd64_gcc12/libFWCoreFramework.so)
==1374585==    by 0x4B832E0: edm::EventProcessor::runToCompletion() (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/lib/el8_amd64_gcc12/libFWCoreFramework.so)
==1374585==    by 0x40840B: tbb::detail::d1::task_arena_function<main::{lambda()#1}::operator()() const::{lambda()#1}, void>::operator()() const (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/bin/el8_amd64_gcc12/cmsRun)
==1374585==    by 0x64419AC: tbb::detail::r1::task_arena_impl::execute(tbb::detail::d1::task_arena_base&, tbb::detail::d1::delegate_base&) (arena.cpp:688)
==1374585==    by 0x40A0F1: main::{lambda()#1}::operator()() const (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/bin/el8_amd64_gcc12/cmsRun)
==1374585==    by 0x4050FF: main (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/bin/el8_amd64_gcc12/cmsRun)
==1374585==  Uninitialised value was created by a heap allocation
==1374585==    at 0x403BEE1: operator new(unsigned long) (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/external/valgrind/3.23.0-143b83b3001a13f5bb2e0a4b5445fed5/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==1374585==    by 0x5503CB00: UnknownInlinedFun (new_allocator.h:137)
==1374585==    by 0x5503CB00: UnknownInlinedFun (allocator.h:188)
==1374585==    by 0x5503CB00: UnknownInlinedFun (alloc_traits.h:464)
==1374585==    by 0x5503CB00: UnknownInlinedFun (stl_vector.h:378)
==1374585==    by 0x5503CB00: UnknownInlinedFun (stl_vector.h:395)
==1374585==    by 0x5503CB00: UnknownInlinedFun (stl_vector.h:332)
==1374585==    by 0x5503CB00: UnknownInlinedFun (stl_vector.h:566)
==1374585==    by 0x5503CB00: UnknownInlinedFun (DigitizerUtility.h:38)
==1374585==    by 0x5503CB00: SiPixelDigitizerAlgorithm::add_noise(PixelGeomDetUnit const*, float, CLHEP::HepRandomEngine*) (SiPixelDigitizerAlgorithm.cc:1829)
==1374585==    by 0x55032F4C: SiPixelDigitizerAlgorithm::digitize(PixelGeomDetUnit const*, std::vector<PixelDigi, std::allocator<PixelDigi> >&, std::vector<PixelDigiSimLink, std::allocator<PixelDigiSimLink> >&, std::vector<PixelDigiAddTempInfo, std::allocator<PixelDigiAddTempInfo> >&, TrackerTopology const*, CLHEP::HepRandomEngine*) (SiPixelDigitizerAlgorithm.cc:1099)
==1374585==    by 0x550203DB: cms::SiPixelDigitizer::finalizeEvent(edm::Event&, edm::EventSetup const&) (SiPixelDigitizer.cc:289)
==1374585==    by 0x49737BCA: edm::MixingModule::finalizeEvent(edm::Event&, edm::EventSetup const&) (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/lib/el8_amd64_gcc12/pluginSimGeneralMixingModulePlugins.so)
==1374585==    by 0x497A0D10: edm::BMixingModule::produce(edm::Event&, edm::EventSetup const&) (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/lib/el8_amd64_gcc12/libMixingBase.so)
==1374585==    by 0x4C88FC2: edm::stream::EDProducerAdaptorBase::doEvent(edm::EventTransitionInfo const&, edm::ActivityRegistry*, edm::ModuleCallingContext const*) (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/lib/el8_amd64_gcc12/libFWCoreFramework.so)
==1374585==    by 0x4C7053B: edm::WorkerT<edm::stream::EDProducerAdaptorBase>::implDo(edm::EventTransitionInfo const&, edm::ModuleCallingContext const*) (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/lib/el8_amd64_gcc12/libFWCoreFramework.so)
==1374585==    by 0x4BF4CF8: std::__exception_ptr::exception_ptr edm::Worker::runModuleAfterAsyncPrefetch<edm::OccurrenceTraits<edm::EventPrincipal, (edm::BranchActionType)1> >(std::__exception_ptr::exception_ptr, edm::OccurrenceTraits<edm::EventPrincipal, (edm::BranchActionType)1>::TransitionInfoType const&, edm::StreamID, edm::ParentContext const&, edm::OccurrenceTraits<edm::EventPrincipal, (edm::BranchActionType)1>::Context const*) (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/lib/el8_amd64_gcc12/libFWCoreFramework.so)
==1374585==    by 0x4BF51F0: edm::Worker::RunModuleTask<edm::OccurrenceTraits<edm::EventPrincipal, (edm::BranchActionType)1> >::execute() (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/lib/el8_amd64_gcc12/libFWCoreFramework.so)
==1374585==    by 0x421B237: tbb::detail::d1::function_task<edm::WaitingTaskList::announce()::{lambda()#1}>::execute(tbb::detail::d1::execution_data&) (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/lib/el8_amd64_gcc12/libFWCoreConcurrency.so)
==1374585==    by 0x64553E0: UnknownInlinedFun (task_dispatcher.h:322)
==1374585==    by 0x64553E0: UnknownInlinedFun (task_dispatcher.h:458)
==1374585==    by 0x64553E0: tbb::detail::r1::task_dispatcher::execute_and_wait(tbb::detail::d1::task*, tbb::detail::d1::wait_context&, tbb::detail::d1::task_group_context&) (task_dispatcher.cpp:168)
==1374585==    by 0x4B7539A: edm::FinalWaitingTask::wait() (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/lib/el8_amd64_gcc12/libFWCoreFramework.so)
==1374585==    by 0x4B82E2E: edm::EventProcessor::processRuns() (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/lib/el8_amd64_gcc12/libFWCoreFramework.so)
==1374585==    by 0x4B832E0: edm::EventProcessor::runToCompletion() (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/lib/el8_amd64_gcc12/libFWCoreFramework.so)
==1374585==    by 0x40840B: tbb::detail::d1::task_arena_function<main::{lambda()#1}::operator()() const::{lambda()#1}, void>::operator()() const (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/bin/el8_amd64_gcc12/cmsRun)
==1374585==    by 0x64419AC: tbb::detail::r1::task_arena_impl::execute(tbb::detail::d1::task_arena_base&, tbb::detail::d1::delegate_base&) (arena.cpp:688)
==1374585==    by 0x40A0F1: main::{lambda()#1}::operator()() const (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/bin/el8_amd64_gcc12/cmsRun)
==1374585==    by 0x4050FF: main (in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02864/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-17-0000/bin/el8_amd64_gcc12/cmsRun)

@makortel
Copy link
Contributor Author

The memory allocation is done in

cmssw/SimTracker/Common/interface/DigitizerUtility.h

Line 38 in 5295006

Amplitude(float amp, float frac) : _amp(amp), _frac(1, frac) {

and accessed in

cmssw/SimTracker/Common/interface/DigitizerUtility.h

Lines 63 to 67 in 5295006

void operator+=(const Amplitude& other) {
_amp += other._amp;
//in case of contribution of noise to the digi
//the MC information are removed
if (other._frac[0] > -0.5) {

I'm not sure what exactly happens in the case of valgrind's warning, but at minimum the operator+=() does not handle the case where _frac is empty().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pending-signatures simulation-pending trk
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@makortel @cmsbuild