Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC3] py2/3 compatibility:drop use of __future__ #46780

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

smuzaffar
Copy link
Contributor

see #46762

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 22, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46780/42764

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)
  • PhysicsTools/NanoAODTools (xpog)
  • RecoLocalMuon/GEMCSCSegment (reconstruction, upgrade)
  • Validation/EventGenerator (dqm, generators)

@Moanwar, @antoniovagnerini, @bbilin, @cmsbuild, @ftorrresd, @hqucms, @jfernan2, @lviliani, @mandrenguyen, @menglu21, @mkirsano, @rseidita, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@AnnikaStein, @bellan, @clelange, @gpetruc, @jhgoh, @lenzip, @missirol, @watson-ij this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46780/42767

@cmsbuild
Copy link
Contributor

Pull request #46780 was updated. @antoniovagnerini, @bbilin, @cmsbuild, @ftorrresd, @hqucms, @lviliani, @menglu21, @mkirsano, @rseidita can you please check and sign again.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c1c448/43039/summary.html
COMMIT: b589c81
CMSSW: CMSSW_15_0_X_2024-11-24-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46780/43039/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 36 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3483722
  • DQMHistoTests: Total failures: 1898
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3481804
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 202 log files, 172 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@antoniovagnerini
Copy link

+dqm

@jfernan2
Copy link
Contributor

+1

1 similar comment
@hqucms
Copy link
Contributor

hqucms commented Nov 25, 2024

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants