Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu development for 14_1_X (4/N) [14_2_X] #46805

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Nov 26, 2024

backport of #46804

PR description:

Development of HLT menus for CMSSW_14_1_X (branch CMSSW_14_2_X): this is the close-out PR for HLT development in the CMSSW_14_1_X cycle.

  • This is the PR for the CMSSW_14_2_X branch, which will then be backported down to 14_1_X (the latter is the release cycle currently used for Run-3 HLT-menu development).
  • These updates correspond to the changes accumulated in the 14_1_X release cycle after the "V1.0" HIon menu for the 2024 PbPb data-taking period was released.

This update includes the integration of the following JIRA tickets:

  • CMSHLT-3382 [HIN] Addition of a L1_FirstCollisionInTrain passthrough trigger for ZDC physics analysis
  • CMSHLT-3386 [ECAL] Downgrading EnergyInDeadEB/EE_FE Warning by setting logWarningEtThreshold_EB/EE_FE parameters in the HLT configuration to -1
  • CMSHLT-3388 [HIN/TRK] New centrality BS trigger for PbPb menu
  • CMSHLT-3390 [HIN/DQM] Misnaming of the output folders for DQM analyzers in HLTDQMPixelReconstructionPPOnAA
  • CMSHLT-3392 [TSG/DQM] Missing collections for HLT dqm client in PbPb 2024 runs
  • CMSHLT-3393 [HIN] New HLT paths for low pT double EG UPC triggers
  • CMSHLT-3394 [HIN/AlCa] Change of L1 seed for AlCa_EcalPhiSymForHI_v in the HIon menu
  • CMSHLT-3395 [HIN] Request for modifying UPC HLT paths for ZDC triggers
  • CMSHLT-3400 [HIN] Sync HIon table with online post-HIRun2024B
  • CMSHLT-3401 [HIN] Sync PRef table with online post-Run2024J

In addition, the following changes are included:

  • bda327e : update of L1T HIon menu in TSG GTs to L1Menu_CollisionsHeavyIons2024_v1_0_6_xml
  • 8d57b55 : move from L1Menu_Collisions2024_v1_3_0_xml to L1Menu_Collisions2024_v1_3_0-d1_xml in autoCondHLT in order to have the same firmware uuid as in the real data-taking
  • 8990e7d : fix buggy customization function customiseHLTFor46647
  • 2b10c73 : update phase1_2024_realistic_hi autoCond key to have the latest 2024 L1T HIon menu: L1Menu_CollisionsHeavyIons2024_v1_0_6_xml (as per this cmsTalk
    • The GT in autoCond was modified to 141X_mcRun3_2024_realistic_HI_v10, which includes the L1 menu required by these HLT updates.
    • The difference from the previous version _v8 in autoCond can be seen here , where one can see that only the L1 menu was updated wrt _v8.

PR validation:

TSG integration tests

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #46804 to CMSSW_14_2_X.

These updates correspond to the changes accumulated in the 14_1_X release cycle after the "V1.0" HIon menu for the 2024 PbPb data-taking period was released.
This update includes the integration of the following JIRA tickets:
- [CMSHLT-3382](https://its.cern.ch/jira/browse/CMSHLT-3382) [HIN] Addition of a L1_FirstCollisionInTrain passthrough trigger for ZDC physics analysis
- [CMSHLT-3386](https://its.cern.ch/jira/browse/CMSHLT-3386) [ECAL] Downgrading EnergyInDeadEB/EE_FE Warning by setting logWarningEtThreshold_EB/EE_FE parameters in the HLT configuration to -1
- [CMSHLT-3388](https://its.cern.ch/jira/browse/CMSHLT-3388) [HIN/TRK] New centrality BS trigger for PbPb menu
- [CMSHLT-3390](https://its.cern.ch/jira/browse/CMSHLT-3390) [HIN/DQM] Misnaming of the output folders for DQM analyzers in HLTDQMPixelReconstructionPPOnAA
- [CMSHLT-3392](https://its.cern.ch/jira/browse/CMSHLT-3392) [TSG/DQM] Missing collections for HLT dqm client in PbPb 2024 runs
- [CMSHLT-3393](https://its.cern.ch/jira/browse/CMSHLT-3393) [HIN] New HLT paths for low pT double EG UPC triggers
- [CMSHLT-3394](https://its.cern.ch/jira/browse/CMSHLT-3394) [HIN/AlCa] Change of L1 seed for AlCa_EcalPhiSymForHI_v in the HIon menu
- [CMSHLT-3395](https://its.cern.ch/jira/browse/CMSHLT-3395) [HIN] Request for modifying UPC HLT paths for ZDC triggers
- [CMSHLT-3400](https://its.cern.ch/jira/browse/CMSHLT-3400) [HIN] Sync HIon table with online post-HIRun2024B
- [CMSHLT-3401](https://its.cern.ch/jira/browse/CMSHLT-3401) [HIN] Sync PRef table with online post-Run2024J
…1_3_0-d1_xml in autoCondHLT in order to have the same firmware uuid as in the real data-taking
@cmsbuild cmsbuild added this to the CMSSW_14_2_X milestone Nov 26, 2024
@mmusich
Copy link
Contributor Author

mmusich commented Nov 26, 2024

type hlt-integration

@mmusich
Copy link
Contributor Author

mmusich commented Nov 26, 2024

enable gpu

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 26, 2024

A new Pull Request was created by @mmusich for CMSSW_14_2_X.

It involves the following packages:

  • Configuration/HLT (hlt)
  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @missirol, @silviodonato this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 26, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Nov 26, 2024

@cmsbuild, please test

@mmusich
Copy link
Contributor Author

mmusich commented Nov 26, 2024

test parameters:

  • workflows = 161, 161.02, 161.03, 161.1, 161.2, 161.3, 161.4, 180.0, 180.1, 181, 181.1

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 920KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0f140c/43095/summary.html
COMMIT: 8990e7d
CMSSW: CMSSW_14_2_X_2024-11-26-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46805/43095/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 7
  • DQMHistoTests: Total histograms compared: 53058
  • DQMHistoTests: Total failures: 32
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 53026
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
  • Checked 24 log files, 30 edm output root files, 7 DQM output files
  • TriggerResults: no differences found

…L1T HIon menu: L1Menu_CollisionsHeavyIons2024_v1_0_6_xml
@cmsbuild
Copy link
Contributor

Pull request #46805 was updated. @Martin-Grunewald, @atpathak, @cmsbuild, @consuegs, @mmusich, @perrotta can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Nov 26, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 924KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0f140c/43102/summary.html
COMMIT: 2b10c73
CMSSW: CMSSW_14_2_X_2024-11-26-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46805/43102/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 62 differences found in the comparisons
  • DQMHistoTests: Total files compared: 56
  • DQMHistoTests: Total histograms compared: 4789314
  • DQMHistoTests: Total failures: 513
  • DQMHistoTests: Total nulls: 160
  • DQMHistoTests: Total successes: 4788621
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 44.528000000000006 KiB( 55 files compared)
  • DQMHistoSizes: changed ( 161.02,... ): 5.566 KiB HLT/Filters
  • Checked 254 log files, 218 edm output root files, 56 DQM output files
  • TriggerResults: found differences in 2 / 54 workflows

GPU Comparison Summary

Summary:

@mmusich
Copy link
Contributor Author

mmusich commented Nov 27, 2024

+hlt

@perrotta
Copy link
Contributor

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7e1e424 into cms-sw:CMSSW_14_2_X Nov 28, 2024
13 checks passed
@mmusich mmusich deleted the HLTdevelopment141X_for142X branch November 28, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants