-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move acquisition deployment off of github-deploy-repo #1042
Comments
it looks like the way tests are run by |
to sanitize https://github.com/cmu-delphi/github-deploy-repo from this repository, we should... remove references to " remove references to " delete these two files: and then do: |
references to " |
For now we are still heavily reliant on github-deploy-repo to write the various parts of delphi-epidata (via deploy.json) to a filesystem so that the expected import locations and module paths work. We also still use the webhook functionality, but only in production (and manually deploy to staging). We can probably make it stop running tests since we do most of that already in Actions CI now, but we'll need to keep it around until we have a different way of getting our bits into an environment that can run them. A good goal would be to containerize "everything" so that we can start looking at more flexible systems to host and run our jobs, as well as local development rigs and workflows. |
This comment may be useful when refactoring our repo paths. |
github-deploy-repo works via a webhook. The webhook is written in PHP, which we are slowly scrubbing from Delphi's active tech stack.
This webhook silently broke after the v4 deployment. While we have developed a fix, a better long-term solution would be to change the deployment mechanism for the acquisition system to something that more closely matches the approaches used by all our other active projects.
The text was updated successfully, but these errors were encountered: