Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor csv_importer.py and csv_to_database.py and covidcast_row.py #1078

Open
dshemetov opened this issue Feb 3, 2023 · 0 comments · May be fixed by #1103
Open

Refactor csv_importer.py and csv_to_database.py and covidcast_row.py #1078

dshemetov opened this issue Feb 3, 2023 · 0 comments · May be fixed by #1103
Labels
acquisition changes acquisition logic code health readability, maintainability, best practices, etc good first issue help wanted refactor Substantial projects to make the code do the same thing, better.

Comments

@dshemetov
Copy link
Contributor

A number of refactors can be done here:

  • csv_importer and csv_to_database are tightly coupled, but with low cohesion; would probably be best if merged together
  • csv_importer validation could likely be handled by Pandas exceptions
  • csv_importer can exit early when detecting a Pandas exception and save time
  • csv_importer can probably share validation with covidcast_row
@dshemetov dshemetov mentioned this issue Feb 3, 2023
Merged
5 tasks
@dshemetov dshemetov added refactor Substantial projects to make the code do the same thing, better. acquisition changes acquisition logic code health readability, maintainability, best practices, etc help wanted good first issue labels Feb 5, 2023
@BrainIsDead BrainIsDead self-assigned this Feb 23, 2023
@BrainIsDead BrainIsDead linked a pull request Mar 3, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
acquisition changes acquisition logic code health readability, maintainability, best practices, etc good first issue help wanted refactor Substantial projects to make the code do the same thing, better.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1078 - Refactor csv_importer.py and csv_to_database.py cmu-delphi/delphi-epidata
2 participants
@dshemetov @BrainIsDead