Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test_covidcast_meta.py with hard value comparisons #924

Open
dshemetov opened this issue Jun 2, 2022 · 0 comments
Open

Update test_covidcast_meta.py with hard value comparisons #924

dshemetov opened this issue Jun 2, 2022 · 0 comments
Labels
help wanted

Comments

@dshemetov
Copy link
Contributor

dshemetov commented Jun 2, 2022 •
edited
Loading

just want to point out that nothing in these tests is actually testing that the meta values were computed correctly, only that the length of the responses returned was correct and that fields like min_time are present. i don't believe that the changes to compute_covidcast_meta warrant and update to that, but it would be good to have at least a few tests that compare hard values in the future.

Originally posted by @dshemetov in #903 (comment)

Related: #897
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@melange396 @dshemetov @nolangormley