Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Bottlenecks from profiling #372

Open
1 of 2 tasks
dshemetov opened this issue Aug 16, 2024 · 1 comment
Open
1 of 2 tasks

[Perf] Bottlenecks from profiling #372

dshemetov opened this issue Aug 16, 2024 · 1 comment

Comments

@dshemetov
Copy link
Contributor

dshemetov commented Aug 16, 2024

Recent profiling profvis_arduous.dingo_20240815.html.zip from exploration-tooling uncovered a couple slow spots in the code here:

I totally don't understand what's going on in (1), but @dsweber2 says @dajmcdon might rewrite that function at some point.

(2) seems like an incorrect use of try catch - the output of the try line is either an error or a tibble, but in either case it runs grepl on the result, which, in the latter case is quite slow. That should be a simple fix: catch the error and grepl only then.

@dajmcdon
Copy link
Contributor

@dshemetov for (2), this function needs to be refactored. See #234 maybe also #248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants