You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I totally don't understand what's going on in (1), but @dsweber2 says @dajmcdon might rewrite that function at some point.
(2) seems like an incorrect use of try catch - the output of the try line is either an error or a tibble, but in either case it runs grepl on the result, which, in the latter case is quite slow. That should be a simple fix: catch the error and grepl only then.
The text was updated successfully, but these errors were encountered:
Recent profiling profvis_arduous.dingo_20240815.html.zip from exploration-tooling uncovered a couple slow spots in the code here:
I totally don't understand what's going on in (1), but @dsweber2 says @dajmcdon might rewrite that function at some point.
(2) seems like an incorrect use of try catch - the output of the try line is either an error or a tibble, but in either case it runs grepl on the result, which, in the latter case is quite slow. That should be a simple fix: catch the error and grepl only then.
The text was updated successfully, but these errors were encountered: