Add a sanity check for delay negation

Author: sei-eschwartz

share/prolog/oorules/insanity.pl

@@ -328,6 +328,18 @@
                   factEmbeddedObject(A, B, C))
     ).
 
+% We committed to a condition being true (or false).  Make sure that it stays
+% that way.
+:- table insanityNegation/1 as incremental.
+insanityNegation(Out) :-
+    negation_commit(G),
+
+    not(G),
+
+    Out = (
+        logwarnln('Consistency checks failed.~nThe condition "~Q" was committed to, but has become false.~n', [G])
+    ).
+
 :- table sanityChecks/1 as incremental.
 sanityChecks(Out) :-
     insanityNoBaseConsistency(Out);
@@ -346,7 +358,8 @@
     insanityInheritanceLoop(Out);
     insanityContradictoryMerges(Out);
     insanityContradictoryNOTConstructor(Out);
-    insanityTwoRealDestructorsOnClass(Out).
+    insanityTwoRealDestructorsOnClass(Out);
+    insanityNegation(Out).
 
 sanityChecks :-
     sanityChecks(Out)