Merge pull request #104 from co-cddo/remove-airtable-code

Remove AirTable code

Author: RobNicholsGDS

app/models/agreement.rb

@@ -1,5 +1,4 @@
 class Agreement < DataTable
-  self.air_table_name = "Information Sharing Agreements"
   self.rapid_table_name = :agreements
   self.rapid_name_field = :agreement_name
 

app/models/agreement_control_person.rb

@@ -8,16 +8,7 @@ class << self
     def populate
       delete_all # Simplest way to ensure records deleted from Airtable do not persist in local database
 
-      air_table_data_source? ? populate_from_airtable : populate_from_rapid
-    end
-
-    def populate_from_airtable
-      Agreement.find_each do |agreement|
-        (agreement.fields["controllers"] || []).each do |control_person_id|
-          control_person = ControlPerson.find_by(record_id: control_person_id)
-          find_or_create_by!(agreement:, control_person:) if control_person.present?
-        end
-      end
+      populate_from_rapid
     end
 
     def populate_from_rapid

app/models/agreement_processor.rb

@@ -8,16 +8,7 @@ class << self
     def populate
       delete_all # Simplest way to ensure records deleted from Airtable do not persist in local database
 
-      air_table_data_source? ? populate_from_airtable : populate_from_rapid
-    end
-
-    def populate_from_airtable
-      Agreement.find_each do |agreement|
-        (agreement.fields["processors"] || []).each do |processor_id|
-          processor = Processor.find_by(record_id: processor_id)
-          find_or_create_by!(agreement:, processor:) if processor.present?
-        end
-      end
+      populate_from_rapid
     end
 
     def populate_from_rapid

app/models/air_table_base.rb

@@ -2,8 +2,4 @@
 
 class ApplicationRecord < ActiveRecord::Base
   primary_abstract_class
-
-  def self.air_table_data_source?
-    Rails.configuration.data_source == :airtable
-  end
 end

app/models/air_table_table.rb

@@ -1,11 +1,7 @@
 class ControlPerson < DataTable
-  self.air_table_name = "Controllers"
   self.rapid_table_name = :controllers
   self.rapid_name_field = :controller_name
 
-  has_many :power_control_people, dependent: :delete_all
-  has_many :powers, through: :power_control_people
-
   has_many :agreement_control_people, dependent: :delete_all
   has_many :agreements, through: :agreement_control_people
 end

app/models/application_record.rb

@@ -1,18 +1,17 @@
 # Classes that inherit from this one store data for each of the main data tables
 
-# For data held in Airtable, the table name used in Airtable will need to be defined
-# in the sub-classes. For example, if you want to store the data for an Airtable "Foo bar"
-# you can:
+# Subclasses of DataTable need to specify the name of the rAPId table the data
+# will be pulled from and which field contains the instance name:
 # ```
 #   class FooBar < DataTable
-#     self.air_table_name = 'Foo bar'
+#     self.rapid_table_name = :my_model
+#     self.rapid_name_field = :my_model_name
 #   end
 # ```
 #
 # With that in place, `FooBar.populate` will pull each of the records from the data source
 # and store them in the data_tables table with the type 'FooBar'.
 class DataTable < ApplicationRecord
-  extend AirtableDataSource
   extend RapidDataSource
 
   include PgSearch::Model
@@ -23,7 +22,7 @@ class DataTable < ApplicationRecord
   }
 
   class << self
-    attr_accessor :air_table_name, :rapid_table_name, :rapid_name_field
+    attr_accessor :rapid_table_name, :rapid_name_field
 
     def populate
       raise "Cannot run on root class - DataTable" if self == DataTable
@@ -55,7 +54,7 @@ def before_populate_save(instance)
     end
 
     def data_from_source
-      air_table_data_source? ? data_from_air_table : data_from_rapid
+      data_from_rapid
     end
 
   private

app/models/concerns/airtable_data_source.rb

@@ -1,11 +1,7 @@
 class Power < DataTable
-  self.air_table_name = "Power Disclosure"
   self.rapid_table_name = :dea_upload_powers
   self.rapid_name_field = :name
 
   has_many :power_agreements
   has_many :agreements, through: :power_agreements
-
-  has_many :power_control_people
-  has_many :control_people, through: :power_control_people
 end