Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce 100% branch coverage #282

Closed
jayvdb opened this issue Aug 4, 2018 · 1 comment
Closed

Enforce 100% branch coverage #282

jayvdb opened this issue Aug 4, 2018 · 1 comment
Assignees
@jayvdb
Labels
area/CI difficulty/low type/tests

Comments

@jayvdb
Copy link
Member

jayvdb commented Aug 4, 2018

With a bunch of exceptions due to old code, we can lock down this repo to comply with the @coala rule of 100% branch coverage, to prevent new accidental additions of code without proper coverage. It is often hard to spot where tests have not provided 100% coverage. We have tools for that. And we have a setup.cfg template for it.

Issues have been created for most of the outstanding test coverage issues, and they will likely be great GCI tasks.
@jayvdb jayvdb self-assigned this Aug 4, 2018
@gitmate-bot
Copy link

GitMate.io thinks the contributor most likely able to help you is @satwikkansal.

jayvdb added a commit to jayvdb/coala-quickstart that referenced this issue Aug 4, 2018
@jayvdb
setup.cfg: Enforce 100% branch coverage
930a77c 
Creates a list of coverage exceptions in .nocover.yaml
which are used in setup.cfg by coverage to ignore them
while ensuring any other parts of the code are fully
tested.

Also rename one function so its signature is on one line
as required for coverage to ignore the entire function.

Closes coala#282
jayvdb added a commit to jayvdb/coala-quickstart that referenced this issue Aug 4, 2018
@jayvdb
.travis.yml: Move moban to separate stage
7fef0b0 
Related to coala#282
@jayvdb jayvdb mentioned this issue Aug 4, 2018
Merged
ishanSrt pushed a commit to ishanSrt/coala-quickstart that referenced this issue Aug 9, 2018
@jayvdb @ishanSrt
.travis.yml: Move moban to separate stage
215dab4 
Related to coala#282
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jayvdb jayvdb

Labels
area/CI difficulty/low type/tests
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jayvdb @gitmate-bot