Skip to content

Commit 5fdd77e

Browse files
committed
feat(exec): allow cocoon vm exec on Windows guests
cocoon-agent v0.1.2 ships with Windows SCM service mode + AF_VSOCK + viosock support, so the historical "not yet available on Windows" guard no longer reflects reality. Drop it; the same `dialHybridVsock` + `client.Run` flow already handles Windows guests with no further changes. Validated on `35.240.182.52` against a 4-deep clone chain: cocoon vm exec win-c{1,2,3} -- powershell -NoProfile -Command ... works on every clone — the vsock path stays up even while the NIC is mid-hot-rebind on `--on-demand` clone3 (issue#28 NDIS-stuck symptom), which makes vsock exec the only host-side control channel that survives clone resume independent of guest networking.
1 parent be35341 commit 5fdd77e

1 file changed

Lines changed: 0 additions & 3 deletions

File tree

cmd/vm/exec.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,6 @@ func (h Handler) Exec(cmd *cobra.Command, args []string) error {
5353
if info.VsockSocket == "" {
5454
return fmt.Errorf("exec: %w (recreate the VM to enable agent exec)", ErrVsockNotConfigured)
5555
}
56-
if info.Config.Windows {
57-
return fmt.Errorf("exec: cocoon-agent is not yet available on Windows guests")
58-
}
5956

6057
envPairs, _ := cmd.Flags().GetStringArray("env")
6158
env, err := parseExecEnv(envPairs)

0 commit comments

Comments
 (0)