fix

Author: CMGS

cmd/core/helpers.go

@@ -133,7 +133,7 @@ func VMConfigFromFlags(cmd *cobra.Command, image string) (*types.VMConfig, error
 	storStr, _ := cmd.Flags().GetString("storage")
 
 	if vmName == "" {
-		vmName = fmt.Sprintf("cocoon-%s", image)
+		vmName = sanitizeVMName(image)
 	}
 
 	memBytes, err := units.RAMInBytes(memStr)
@@ -176,3 +176,16 @@ func FormatSize(bytes int64) string {
 func IsURL(ref string) bool {
 	return strings.HasPrefix(ref, "http://") || strings.HasPrefix(ref, "https://")
 }
+
+// sanitizeVMName derives a safe VM name from an image reference.
+// Strips registry prefix (everything before the last '/'), replaces ':' with '-',
+// and prepends "cocoon-".
+// e.g. "ghcr.io/foo/ubuntu:24.04" → "cocoon-ubuntu-24.04"
+func sanitizeVMName(image string) string {
+	name := image
+	if i := strings.LastIndex(name, "/"); i >= 0 {
+		name = name[i+1:]
+	}
+	name = strings.ReplaceAll(name, ":", "-")
+	return "cocoon-" + name
+}

hypervisor/cloudhypervisor/cloudhypervisor.go

@@ -100,14 +100,20 @@ func (ch *CloudHypervisor) Delete(ctx context.Context, refs []string, force bool
 }
 
 // resolveRefs batch-resolves refs to exact VM IDs under a single lock.
+// Duplicate refs that resolve to the same ID are silently deduplicated.
 func (ch *CloudHypervisor) resolveRefs(ctx context.Context, refs []string) ([]string, error) {
 	var ids []string
 	return ids, ch.store.With(ctx, func(idx *hypervisor.VMIndex) error {
+		seen := make(map[string]struct{}, len(refs))
 		for _, ref := range refs {
 			id, err := hypervisor.ResolveVMRef(idx, ref)
 			if err != nil {
 				return fmt.Errorf("resolve %q: %w", ref, err)
 			}
+			if _, ok := seen[id]; ok {
+				continue
+			}
+			seen[id] = struct{}{}
 			ids = append(ids, id)
 		}
 		return nil