Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cocos compile not working for paths with whitespaces #331

Open
hamburml opened this issue Jan 13, 2016 · 3 comments
Open

cocos compile not working for paths with whitespaces #331

hamburml opened this issue Jan 13, 2016 · 3 comments

Comments

@hamburml
Copy link

Hi!

As stated I am unable to compile my project when the path to cocos2d-x, cocos project, ant and everything else needed contains a whitespace.

I tried to fix it myself (https://github.com/cocos2d/cocos2d-console/blob/v3/plugins/plugin_package/plugin_package.py#L39) but I can't find this file inside my cocos2d-console. I would have added quotes to the path but yeah.. the file doesn't exist (i am using cocos2d-x 3.8). I know I simply could remove the whitespaces but than I would need to change the settings in all other programms which I use. And to be honest, that doesn't fix the problem ;)

@leiradel
Copy link

I've added double quotes surrouding the path at build_android, line 183:

command = "%s update project -t %s -p \"%s\"" % (cocos.CMDRunner.convert_path_to_cmd(sdk_tool_path), target_str, manifest_path)

and now it works fine on Windows. I don't know what this change will do on Linux and Mac...

@leiradel
Copy link

Oops, talked too soon. There are other places where paths with spaces cause problems. I'll update this issue if I can fix them.

@leiradel
Copy link

I've added double quotes to lines 296, 299 and 301, but:

Android NDK: ERROR: You NDK_MODULE_PATH variable contains spaces
Android NDK: Please fix the error and start again.

I'll remove the whitespaces and be done with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants