Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Report #7

Open
c4-bot-3 opened this issue Sep 24, 2024 · 3 comments
Open

QA Report #7

c4-bot-3 opened this issue Sep 24, 2024 · 3 comments
Labels
3rd place bug Something isn't working grade-a Q-03 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@c4-bot-3
Copy link
Contributor

See the markdown file with the details of this report here.

@c4-bot-3 c4-bot-3 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Sep 24, 2024
c4-bot-1 added a commit that referenced this issue Sep 24, 2024
c4-bot-7 added a commit that referenced this issue Sep 24, 2024
@b-hrytsak
Copy link

L-01: Useful

(Disputed) L-02: Not required, as the change in voting power is expected, occurs between the NFTs of the same user, and the only factor that matters is the timing of the transaction. The change in voting power decreases linearly over time, and slippage with repeated transactions will lead to the same result.

(Disputed) L-03: Update of the epoch between votes is not included (it is not updated automatically, but by calling Minter:update_period()) and Publicly Known Issues "Freezing the user's voting power at the time of voting at the beginning of the epoch, which gives them more voting power than they will have actually at the end of the epoch"

(Disputed) L-04: Permanent locking is responsible for keeping the voice power of the veNFT at its maximum level, so the transmission does not harm anything

(Disputed) L-05: A user has the right to claim previously earned rewards, even if further rewards will no longer be accrued.

@c4-judge
Copy link

alcueca marked the issue as grade-a

@liveactionllama
Copy link

For awarding purposes, C4 staff have marked as 3rd place.

@C4-Staff C4-Staff added the Q-03 label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd place bug Something isn't working grade-a Q-03 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Development

No branches or pull requests

5 participants