Merge pull request #497 from code0-tech/fix/grpc-flow-serialization

Fix grpc flow serialization

Author: Taucher2003

app/grpc/flow_handler.rb

@@ -21,6 +21,8 @@ def self.update_started(runtime_id)
       end
     end
 
+    # TODO: Add check to check for primary runtime conflicts
+
     send_update(
       Tucana::Sagittarius::FlowResponse.new(
         flows: Tucana::Shared::Flows.new(

app/models/flow.rb

@@ -7,16 +7,16 @@ class Flow < ApplicationRecord
   belongs_to :return_type, class_name: 'DataType', optional: true
   belongs_to :starting_node, class_name: 'NodeFunction'
 
-  has_many :flow_settings
+  has_many :flow_settings, class_name: 'FlowSetting', inverse_of: :flow
 
   def to_grpc
     Tucana::Shared::Flow.new(
-      id: id,
+      flow_id: id,
       project_id: project.id,
-      flow_type_id: flow_type.identifier,
-      data_types: [], # TODO
-      input_type_id: input_type&.identifier,
-      return_type_id: return_type&.identifier,
+      type: flow_type.identifier,
+      data_types: [], # TODO: when data types are creatable
+      input_type_identifier: input_type&.identifier,
+      return_type_identifier: return_type&.identifier,
       settings: flow_settings.map(&:to_grpc),
       starting_node: starting_node.to_grpc
     )

app/models/flow_setting.rb

@@ -7,7 +7,7 @@ def to_grpc
     Tucana::Shared::FlowSetting.new(
       database_id: id,
       flow_setting_id: flow_setting_id,
-      object: Tucana::Shared::Struct.from_ruby(object)
+      object: Tucana::Shared::Struct.from_hash(object)
     )
   end
 end

app/models/node_function.rb

@@ -41,9 +41,9 @@ def validate_recursion
   end
 
   def to_grpc
-    Tucana::NodeFunction.new(
-      data_base_id: id,
-      runtime_function: runtime_function.to_grpc,
+    Tucana::Shared::NodeFunction.new(
+      database_id: id,
+      runtime_function_id: runtime_function.runtime_name,
       parameters: node_parameters.map(&:to_grpc),
       next_node: next_node&.to_grpc
     )

app/models/node_parameter.rb

@@ -11,7 +11,7 @@ class NodeParameter < ApplicationRecord
   def to_grpc
     param = Tucana::Shared::NodeParameter.new(
       database_id: id,
-      runtime_parameter_id: runtime_parameter&.identifier
+      runtime_parameter_id: runtime_parameter.runtime_name
     )
 
     if literal_value.present?

spec/factories/flows.rb

@@ -5,5 +5,8 @@
     project factory: %i[namespace_project]
     flow_type
     starting_node factory: %i[node_function]
+    flow_settings { [] }
+    input_type { nil }
+    return_type { nil }
   end
 end

spec/models/flow_spec.rb

@@ -14,4 +14,73 @@
 
     it { is_expected.to have_many(:flow_settings) }
   end
+
+  describe '#to_grpc' do
+    let(:flow) do
+      create(:flow,
+             flow_settings: [
+               create(:flow_setting,
+                      flow_setting_id: 'example_key',
+                      object: { some_key: 'some_value' })
+             ],
+             starting_node: create(:node_function,
+                                   node_parameters: [
+                                     create(:node_parameter,
+                                            runtime_parameter: create(:runtime_parameter_definition,
+                                                                      data_type: create(:data_type_identifier,
+                                                                                        generic_key: 'T')))
+                                   ]))
+    end
+
+    it 'matches the model' do
+      grpc_object = flow.to_grpc
+
+      expect(grpc_object.to_h).to eq({
+                                       data_types: [],
+                                       flow_id: flow.id,
+                                       project_id: flow.project.id,
+                                       type: flow.flow_type.identifier,
+                                       input_type_identifier: flow.input_type&.identifier || '',
+                                       return_type_identifier: flow.return_type&.identifier || '',
+                                       starting_node: {
+                                         database_id: flow.starting_node.id,
+                                         next_node: nil,
+                                         runtime_function_id: flow.starting_node.runtime_function.runtime_name,
+                                         parameters: [
+                                           {
+                                             database_id: flow.starting_node.node_parameters.first.id,
+                                             runtime_parameter_id:
+                                               flow.starting_node.node_parameters.first.runtime_parameter.runtime_name,
+                                             function_value: nil,
+                                             literal_value: {
+                                               bool_value: false,
+                                               list_value: nil,
+                                               null_value: :NULL_VALUE,
+                                               number_value: 0.0,
+                                               string_value: flow.starting_node.node_parameters.first.literal_value,
+                                               struct_value: nil,
+                                             },
+                                             reference_value: nil,
+                                           }
+                                         ],
+                                       },
+                                       settings: [
+                                         database_id: flow.flow_settings.first.id,
+                                         flow_setting_id: flow.flow_settings.first.flow_setting_id,
+                                         object: {
+                                           fields: {
+                                             'some_key' => {
+                                               bool_value: false,
+                                               list_value: nil,
+                                               null_value: :NULL_VALUE,
+                                               number_value: 0.0,
+                                               string_value: flow.flow_settings.first.object['some_key'],
+                                               struct_value: nil,
+                                             },
+                                           },
+                                         }
+                                       ],
+                                     })
+    end
+  end
 end